Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change mutex to use logical_device_id #416

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Change mutex to use logical_device_id #416

merged 2 commits into from
Dec 18, 2024

Conversation

broskoTT
Copy link
Contributor

@broskoTT broskoTT commented Dec 18, 2024

Issue

Related to #418

Description

This makes working with this part of the code easier. Both logical_chip_id and pci_device_id is fixed on specific system, so there is no functional change here.
The motivation is that this change makes it easier to work and refactor the locking mechanism.

List of the changes

  • Changed creation of mutexes to use logical_device_id
  • Changed the way mutexes are fetched to use logical_device_id

Testing

CI testing should be enough

API Changes

There are no API changes in this PR.

@broskoTT broskoTT requested a review from pjanevskiTT December 18, 2024 10:12
@broskoTT broskoTT enabled auto-merge (squash) December 18, 2024 13:11
@broskoTT broskoTT merged commit d54ffc7 into main Dec 18, 2024
19 checks passed
@broskoTT broskoTT deleted the brosko/logical_mutex branch December 18, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants