Remove setup_core_to_tlb_map #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
pjanevskiTT
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
Nice. One thing, which probably wasn't working even before your change, is calling configure_tlb twice for different cores and the same index, so some of our maps will have two cores pointing to the same index, which obviously is not correct. That is why there was a requirement that mapping function is 1:1 I guess. Per offline discussion, open an issue on this and maybe leave a comment somewhere to fix this. This problem will go away with some kind of TLB manager, but it would be nice just to be aware of this problem right now
broskoTT
force-pushed
the
brosko/core_to_tlb_map
branch
from
96ed817 to
00169c2
Compare
broskoTT
added a commit
to tenstorrent/tt-metal
that referenced
this pull request
Dec 17, 2024
### Ticket Related to #13948 ### Problem description This API call is unnecessary since all the needed information is already passed during "configure_tlb" calls. Related to tenstorrent/tt-umd#403 ### What's changed - setup_core_to_tlb_map is removed, functionality should stay the same ### Checklist - [x] All post-commit tests : https://github.com/tenstorrent/tt-metal/actions/runs/12376643291 - [ ] Blackhole post-commit tests : https://github.com/tenstorrent/tt-metal/actions/runs/12376645486 - [x] (Single-card) Model perf tests : https://github.com/tenstorrent/tt-metal/actions/runs/12376647574 - [x] (Single-card) Device perf regressions : https://github.com/tenstorrent/tt-metal/actions/runs/12376649607 - [ ] (T3K) T3000 unit tests : https://github.com/tenstorrent/tt-metal/actions/runs/12376651625 - [ ] (T3K) T3000 demo tests : https://github.com/tenstorrent/tt-metal/actions/runs/12376653954 - [ ] (TG) TG unit tests : https://github.com/tenstorrent/tt-metal/actions/runs/12376656331 - [ ] (TG) TG demo tests : https://github.com/tenstorrent/tt-metal/actions/runs/12376658168 - [ ] (TGG) TGG unit tests : https://github.com/tenstorrent/tt-metal/actions/runs/12376660071 - [x] (TGG) TGG demo tests : https://github.com/tenstorrent/tt-metal/actions/runs/12376661988
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Related to #44 but also on a path of #351
Description
This function in API is a surplus. All the info is already available to the Cluster class through configure_tlb calls.
This is initial PR which changes the API. The following PR won't change the API but will restructure functions internally to introduce TLBManager class.
List of the changes
Testing
Covered through existing tests.
API Changes
This PR has API changes: