Coordinate manager maps redesign #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @broskoTT @tt-vjovanovic for useful tips on previous PR, I will implement other suggestions later on, with this we have baseline to support API changes to Cluster |
nhuang-tt
reviewed
Dec 6, 2024
tt-vjovanovic
requested changes
Dec 9, 2024
broskoTT
approved these changes
Dec 10, 2024
pjanevskiTT
force-pushed
the
pjanevski/coord_manager_impl
branch
3 times, most recently
from
f93ee94 to
8e69799
Compare
tt-vjovanovic
approved these changes
Dec 11, 2024
pjanevskiTT
force-pushed
the
pjanevski/coord_manager_impl
branch
from
fd2ad89 to
540cf7a
Compare
pjanevskiTT
force-pushed
the
pjanevski/coord_manager_impl
branch
from
540cf7a to
51ee2e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Some parts of #355
Description
Redesign maps of the Coordinate Manager class. Instead of per core type maps, we use one map now for all core types. Virtual to physical to translated mappings are now implemented for harvested coordinates as well. We may want to use those cores sometimes so in order to support proper reading/writing to these cores. Now all translations are going throug the physical (NOC0) coordinate system, since soc descriptors are in physical coordinate system, and each core has those coordinates.
List of the changes
Testing
Existing unit tests, added more
API Changes
No API changes