Build ubench in CI (#305) #340
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelsmithTT
approved these changes
Nov 27, 2024
|
@joelsmithTT I repeated the same PR as original one, and now you can see the failing runs for building tt_metal (which is the reason why I reverted the original one) |
|
@joelsmithTT how do we build and run these benchmarks, can you add docs in the main README as part of this PR? |
### Issue N/A ### Description tests/microbenchmark wasn't getting built by CI ### List of the changes modify CI yaml to build it with the unit tests ### Testing Builds locally, CI test pending ### API Changes There are no API changes in this PR.
joelsmithTT
force-pushed
the
brosko/repeat2
branch
from
e834056 to
32dd17e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Original PR was #305 and then reverted in #335
Description
tests/microbenchmark wasn't getting built by CI
List of the changes
modify CI yaml to build it with the unit tests
Testing
Builds locally, CI test pending
API Changes
There are no API changes in this PR.