Add IOMMU support #338
Merged
Add IOMMU support #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelsmithTT
requested review from
broskoTT,
pjanevskiTT and
alewycky-tenstorrent
alewycky-tenstorrent
approved these changes
Nov 26, 2024
broskoTT
reviewed
Dec 3, 2024
pjanevskiTT
approved these changes
Dec 4, 2024
|
I think it would be nice to add a README somewhere in the repo which explains how IOMMU can be setup, if additional setup from the default Linux setup is necessary |
joelsmithTT
force-pushed
the
joelsmith/joelsmith/iommu-support
branch
from
5832c26 to
90c09f1
Compare
|
RE: README - I created #370 to track further work on this, which includes documenting it. |
joelsmithTT
force-pushed
the
joelsmith/joelsmith/iommu-support
branch
from
90c09f1 to
3f908eb
Compare
This implementation is not going to work very well for large allocations. The problem is detailed in a comment in the code.
joelsmithTT
force-pushed
the
joelsmith/joelsmith/iommu-support
branch
from
3f908eb to
b827063
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation is not going to work very well for large allocations. The problem is detailed in a comment in the code. This is something we will have to address before we can deploy (i.e. enable system IOMMU in our infra).
Issue
#257
Description
Adds support for using a normal (i.e. not backed by 1G page) buffer for sysmem. This requires a system with IOMMU enabled and not in passthrough mode, and also a recent (>= 1.29.0) KMD.
List of the changes
Testing
Manual testing on my development machine.
API Changes
There are no API changes in this PR.