Change simulation logging to debug level #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhullar-tt
approved these changes
Nov 28, 2024
Hmm, yea in terms of CI for simulators, I'll have timeouts set for now if anything hangs. I'm not sure how to get a progress indicator though :( |
vtangTT
force-pushed
the
vtangTT/simulator_qol
branch
from
7885250 to
cf40208
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
(Link to Github issue(s))
Description
Before, when running with simulator this would spam the output because we would continuously poll the device at the same address.
List of the changes
Changed to debug log level.
Testing
This is a logging change and does not change functionality.
API Changes
There are no API changes in this PR.