Simplify hugepage code, Chapter I #332
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelsmithTT
force-pushed
the
joelsmith/joelsmith/simplify-hugepage-code-v4
branch
3 times, most recently
from
2d83b7e to
18a73fe
Compare
broskoTT
reviewed
Dec 3, 2024
| } | ||
|
|
||
| // Prefer allocations on the NUMA node associated with the device. | ||
| numa_set_preferred(numa_node); |
There was a problem hiding this comment.
Can you please create a tt_metal branch which consumes this UMD commit, and then run tt_metal CI? We don't have machines on our CI that are affected by the change in this PR.
You could run these:
"all-post-commit-workflows.yaml"
"t3000-unit-tests.yaml"
"tg-unit-tests.yaml"
"tgg-unit-tests.yaml"
There was a problem hiding this comment.
This exposed deficiencies in Metal CI, which is running tests that request more hugepages than are actually provisioned.
broskoTT
reviewed
Dec 3, 2024
broskoTT
approved these changes
Dec 3, 2024
pjanevskiTT
approved these changes
Dec 4, 2024
joelsmithTT
force-pushed
the
joelsmith/joelsmith/simplify-hugepage-code-v4
branch
2 times, most recently
from
513c37d to
1003a47
Compare
broskoTT
reviewed
Dec 12, 2024
broskoTT
reviewed
Dec 12, 2024
Also remove the cruft that sprouted up to support its continued existence in UMD Remove const int& antipattern Use libnuma
joelsmithTT
force-pushed
the
joelsmith/joelsmith/simplify-hugepage-code-v4
branch
from
3c2eb8f to
1ea6f57
Compare
Rather than make it use a host memory channel, allow Cluster construction to succeed with zero. Insert a check in the remote IO code paths to emit an actionable error message if there is no available sysmem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#254
Description
Part 1 of an effort to simplify the hugepage scheme for shared memory between device and host. Initial work on this also removed hugetlbfs aspects of the setup, but I will save that for part 2.
List of the changes
Clusterasconst uint32 &.Testing
CI
API Changes
This PR has API changes, but they should not break anything. Metal already requires libnuma.
If moving to libnuma from hwloc is a problem, there's a commit that uses hwloc instead that we can use.