Fix address types #328
Merged
Fix address types #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
broskoTT
reviewed
Nov 25, 2024
|
Slightly related to #281 |
broskoTT
approved these changes
Nov 25, 2024
I might as well fix this too. |
joelsmithTT
commented
Nov 25, 2024
joelsmithTT
commented
Nov 25, 2024
pjanevskiTT
approved these changes
Nov 25, 2024
broskoTT
reviewed
Nov 26, 2024
joelsmithTT
force-pushed
the
joelsmith/joelsmith/fix-address-type
branch
from
b2bdd5c to
7cbcae5
Compare
This was referenced Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#303
Description
Using signed integer for address is wrong and can cause bugs due to sign extension since UMD represents addresses as uint64_t internally. 32 bits is unnecessarily restrictive (there are address spaces in the chips that reach beyond 0x7fffffff that I might want to configure a static window for).
List of the changes
configure_tlbmethodstd::prefixingTesting
CI
API Changes
This PR has API changes, but it shouldn't break anything.