Allow passing optional TensixSoftResetOptions to assert risc reset at core API #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
broskoTT
approved these changes
Nov 15, 2024
Yes I will investigate that |
broskoTT
reviewed
Nov 18, 2024
abhullar-tt
force-pushed
the
abhullar/assert-reset
branch
2 times, most recently
from
e306ed0 to
a2591d7
Compare
abhullar-tt
force-pushed
the
abhullar/assert-reset
branch
from
a2591d7 to
8c5aa30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#307
Description
Mirror of #292 so we can assert risc reset back to initial state.
List of the changes
Added an optional parameter to assert_risc_reset_at_core API
Testing
Expanded deassert risc reset at core to go through assert sequences as well
API Changes
This PR has non-breaking API changes