Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coordinate systems docs #223

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

pjanevskiTT
Copy link
Contributor

Write a doc about coordinate systems. Base for this document is open-umd document which explains all coordinate systems we have

Note for reviews

Feel free to suggest any naming conventions for these coordinate systems. Naming from the initial doc is going to be followed for now, just because it seems that this is mostly accepted across different tenstorrent products (syseng tools, tt-metal, tt-umd)

@pjanevskiTT pjanevskiTT self-assigned this Oct 28, 2024
@pjanevskiTT
Copy link
Contributor Author

Comment from original harvesting PR #202 (comment)

@pjanevskiTT
Copy link
Contributor Author

One more comment from original PR #202 (comment)

@pjanevskiTT pjanevskiTT mentioned this pull request Oct 28, 2024
15 tasks
@alewycky-tenstorrent
Copy link

Suggestion on naming:

  • Physical: actual chip layout, not used by SW
  • NOC post-translate: the burned-in NOC coordinates (currently "Physical")
  • NOC pre-translate: NOC translation LUT input coordinates (currently "HW translated")
  • Virtualized: no change (virtualized is the coord space that makes NOC pre-translate look like a chip without translation at all)
  • Logical: no change (logical is the coord space with just tensixes based at 0-0?)

Also I suggest addressing them in this order (or the reverse) because that's how they are layered.

@pjanevskiTT pjanevskiTT force-pushed the pjanevski/harvesting_docs branch from 50f18df to 79e7d7e Compare October 30, 2024 14:54
@pjanevskiTT pjanevskiTT force-pushed the pjanevski/harvesting_docs branch from 79e7d7e to ef88bfb Compare November 26, 2024 12:36
@pjanevskiTT pjanevskiTT force-pushed the pjanevski/harvesting_docs branch from ef88bfb to 0dbb38f Compare November 26, 2024 13:50
@pjanevskiTT
Copy link
Contributor Author

@joelsmithTT I know you had useful remarks about original harvesting docs. Let me know if you think docs/coordinate_systems.md is a step in the right direction, in order to continue working on expanding the docs here

fyi @broskoTT

@pjanevskiTT pjanevskiTT force-pushed the pjanevski/harvesting_docs branch from ff60e39 to 3b6698a Compare November 26, 2024 15:26
Comment on lines +104 to +106
## Physical Coordinates

These are the NOC coordinates that the hardware understands, there are two distinct variations for NOC0 and NOC1. In hardware, each node is given an ID (which is different for each NOC), represented as x-y pair, which can be used to identify this node. In the SOC descriptor, physical coordinates are specified for NOC0.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason we use the word physical for these? I think it'd be clearer to call them NOC coordinates.

The physical layout of the chip (if you are looking down at it) is not consistent with what we have been calling "physical" coordinates.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I know and I agree, I can rename that both in the docs and in the CoreCoord

@pjanevskiTT pjanevskiTT mentioned this pull request Nov 27, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants