-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coordinate systems docs #223
base: main
Are you sure you want to change the base?
Conversation
Comment from original harvesting PR #202 (comment) |
One more comment from original PR #202 (comment) |
Suggestion on naming:
Also I suggest addressing them in this order (or the reverse) because that's how they are layered. |
50f18df
to
79e7d7e
Compare
79e7d7e
to
ef88bfb
Compare
ef88bfb
to
0dbb38f
Compare
@joelsmithTT I know you had useful remarks about original harvesting docs. Let me know if you think fyi @broskoTT |
ff60e39
to
3b6698a
Compare
## Physical Coordinates | ||
|
||
These are the NOC coordinates that the hardware understands, there are two distinct variations for NOC0 and NOC1. In hardware, each node is given an ID (which is different for each NOC), represented as x-y pair, which can be used to identify this node. In the SOC descriptor, physical coordinates are specified for NOC0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason we use the word physical for these? I think it'd be clearer to call them NOC coordinates.
The physical layout of the chip (if you are looking down at it) is not consistent with what we have been calling "physical" coordinates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I know and I agree, I can rename that both in the docs and in the CoreCoord
Write a doc about coordinate systems. Base for this document is open-umd document which explains all coordinate systems we have
Note for reviews
Feel free to suggest any naming conventions for these coordinate systems. Naming from the initial doc is going to be followed for now, just because it seems that this is mostly accepted across different tenstorrent products (syseng tools, tt-metal, tt-umd)