Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check KMD version prior to querying device info #173

Merged
merged 4 commits into from
Nov 23, 2024
Merged

Check KMD version prior to querying device info #173

merged 4 commits into from
Nov 23, 2024

Conversation

joelsmithTT
Copy link
Contributor

No description provided.

@joelsmithTT joelsmithTT force-pushed the joelsmith/kmd-version-check branch from c42bcf9 to 626cbc2 Compare October 17, 2024 22:53
@broskoTT broskoTT linked an issue Nov 6, 2024 that may be closed by this pull request
Add KMD version check #133
Closed
@joelsmithTT joelsmithTT force-pushed the joelsmith/kmd-version-check branch from 626cbc2 to 9a8ada8 Compare November 8, 2024 16:34
broskoTT
broskoTT reviewed Nov 12, 2024
View reviewed changes
device/CMakeLists.txt Outdated Show resolved Hide resolved
joelsmithTT
joelsmithTT commented Nov 12, 2024
View reviewed changes
.clang-format Outdated Show resolved Hide resolved
broskoTT
broskoTT reviewed Nov 12, 2024
View reviewed changes
tests/api/test_semver.cpp Outdated Show resolved Hide resolved
broskoTT
broskoTT reviewed Nov 12, 2024
View reviewed changes
.clang-format Outdated Show resolved Hide resolved
@joelsmithTT joelsmithTT force-pushed the joelsmith/kmd-version-check branch from b87b20b to d70cd71 Compare November 12, 2024 15:46
@joelsmithTT joelsmithTT force-pushed the joelsmith/kmd-version-check branch from 1626940 to 8161574 Compare November 18, 2024 19:56
broskoTT
broskoTT approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@broskoTT broskoTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing many comments I've left

device/pcie/pci_device.cpp Outdated Show resolved Hide resolved
@joelsmithTT
Add common version handling code
4280e0e 
Add semver_t type into common to handle version numbers, based on semver
2.0.0 but more permissive since TT-KMD reports non-compliant version
strings like "1.29" and "1.28-bh2".  Add logic to PCIDevice class to
report KMD version during device initialization.
@joelsmithTT
format
1d48007
@joelsmithTT
Improve log message
81044f2
@joelsmithTT joelsmithTT force-pushed the joelsmith/kmd-version-check branch from 58001fd to 81044f2 Compare November 23, 2024 19:18
@joelsmithTT joelsmithTT enabled auto-merge (squash) November 23, 2024 19:36
@joelsmithTT joelsmithTT merged commit c51e692 into main Nov 23, 2024
9 of 12 checks passed
@joelsmithTT joelsmithTT deleted the joelsmith/kmd-version-check branch November 23, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@broskoTT broskoTT broskoTT approved these changes

@pjanevskiTT pjanevskiTT Awaiting requested review from pjanevskiTT

@blozano-tt blozano-tt Awaiting requested review from blozano-tt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add KMD version check
2 participants
@joelsmithTT @broskoTT