Add embedding weight cast from float32 to bfloat16 #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ch.py to cast weight to bfloat16 if they are float32.
dgolubovicTT
force-pushed
the
dgolubovic/add-embedding-weight-cast
branch
from
63fcdb6 to
0a429cf
Compare
nvukobratTT
approved these changes
Dec 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since ttnn only supports weight of embedding to be bfloat16, cast is introduced as a temporary solution until tt-mlir supports casting of embedding weight in workaround pass (tenstorrent/tt-mlir#1657). This enables llama embedding to work.