Uplift tt-mlir version and skip the failing tests (Nov-12-2024). #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmanzoorTT
requested review from
AleksKnezevic,
LPanosTT,
uazizTT and
ddilbazTT
|
The failure is due to an issue reported in tt-xla as well tenstorrent/tt-xla#57. Referencing it here so slice tests are enabled once the issue is resolved. |
uazizTT
approved these changes
Nov 8, 2024
tests/torch/test_basic.py
Outdated
| @@ -285,6 +285,7 @@ def forward(self, x): | |||
| @pytest.mark.parametrize( | |||
| "begin, end, dim", [*dim2_cases, *dim3_cases, *dim0_cases, *dim1_cases] | |||
| ) | |||
| @pytest.mark.skip("AssertionError: ATOL too high: nan vs 0.01") | |||
There was a problem hiding this comment.
Is it all of the slice tests that are failing? Could we just skip some of them?
There was a problem hiding this comment.
slice test is only working for dim=3. I have skipped remaining tests.
mmanzoorTT
force-pushed
the
mmanzoor/ttmlir-uplift
branch
3 times, most recently
from
fe4d490 to
4bb95ff
Compare
mmanzoorTT
force-pushed
the
mmanzoor/ttmlir-uplift
branch
from
4bb95ff to
78565ee
Compare
mmanzoorTT
changed the title
| @@ -286,6 +286,10 @@ def forward(self, x): | |||
| "begin, end, dim", [*dim2_cases, *dim3_cases, *dim0_cases, *dim1_cases] | |||
| ) | |||
| def test_slice(begin, end, dim): | |||
| # Slice test is only working for dim=3; skipping all other tests. | |||
| if dim != 3: | |||
There was a problem hiding this comment.
Please also add an issue tracking this bug so that we'll eventually follow up and remove the skip.
AleksKnezevic
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.