Uplift third_party/tt-metal to 2024-11-20 #952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsmithtt
approved these changes
Oct 20, 2024
vmilosevic
changed the title
nsmithtt
approved these changes
Oct 21, 2024
vmilosevic
changed the title
nsmithtt
approved these changes
Oct 22, 2024
vmilosevic
changed the title
nsmithtt
approved these changes
Oct 23, 2024
vmilosevic
changed the title
nsmithtt
approved these changes
Oct 24, 2024
vmilosevic
changed the title
nsmithtt
approved these changes
Oct 25, 2024
vmilosevic
changed the title
nsmithtt
approved these changes
Oct 26, 2024
vmilosevic
changed the title
nsmithtt
approved these changes
Oct 27, 2024
vmilosevic
changed the title
nsmithtt
approved these changes
Oct 28, 2024
vmilosevic
changed the title
kmabeeTT
requested review from
jnie-TT,
kmabeeTT,
AleksKnezevic and
pilkicTT
as code owners
tapspatel
approved these changes
Nov 14, 2024
vmilosevic
changed the title
nsmithtt
approved these changes
Nov 15, 2024
vmilosevic
changed the title
nsmithtt
approved these changes
Nov 16, 2024
vmilosevic
changed the title
nsmithtt
approved these changes
Nov 17, 2024
vmilosevic
changed the title
nsmithtt
approved these changes
Nov 18, 2024
vmilosevic
changed the title
nsmithtt
approved these changes
Nov 19, 2024
vmilosevic
changed the title
nsmithtt
approved these changes
Nov 20, 2024
- Recent tt-metal check will fire this (and use ShardSpec) even for Interleaved tensors. >> Tensor with shape ttnn.Shape([1, 100[128], 3[32], 100[128]]) cannot be sharded because alignment will have rank greater than 2!
kmabeeTT
approved these changes
Nov 20, 2024
|
Hmm premature merge? The CI had a failing job (which was spurious network issue...phew). https://github.com/tenstorrent/tt-mlir/actions/runs/11941346198/job/33285990338 |
jserbedzijaTT
pushed a commit
that referenced
this pull request
Nov 25, 2024
* Uplift third_party/tt-metal to 2024-11-20 * Change createMemoryConfig() to not return ShardSpec if INTERLEAVED - Recent tt-metal check will fire this (and use ShardSpec) even for Interleaved tensors. >> Tensor with shape ttnn.Shape([1, 100[128], 3[32], 100[128]]) cannot be sharded because alignment will have rank greater than 2! --------- Co-authored-by: Kyle Mabee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uplifts the third_party/tt-metal to the