Migrate tt-explorer into tt-mlir repo #945
Conversation
There was a problem hiding this comment.
As mentioned throughout the code comments, the changes are valid and exciting (bar some cosmetic differences).
My main concern is that I've been working on a pretty major shift into how MLIR will be parsed by tt-adapter to allow for the visualization of TTNN modules. For this reason, I think that if this initial migration isn't too urgent, we could add these changes in from tt-adapter without much conflict. My schedule is to have these changes done over the weekend and ready by Monday. Let me know what you think
| op_to_graph_node = dict() | ||
|
|
||
| for op in module.body.operations: | ||
| append_later = [] |
There was a problem hiding this comment.
Any reason we're choosing not to parse the ModuleOps? They would represent the op iter at this level.
There was a problem hiding this comment.
It did not seem useful visually.
@vprajapati-tt There is no rush in migrating this over, tho i don't want to keep development going in the other repos for long. I think that it makes sense to wait for you to finish the changes and then figure out what the initial commit will look like. |
|
|
||
| for operand in op.operands: | ||
| if operand.owner == block and operand not in op_to_graph_node: | ||
| # This is a constant and we need to create a node for it. |
There was a problem hiding this comment.
@vprajapati-tt While playing with the tool it seemed like it was very useful to have inputs / weights represented as visual nodes as well. What do you think?
There was a problem hiding this comment.
Yeah! This makes sense, I didn't do too much testing with graphs that had weights so this is reasonable.
odjuricicTT
changed the title
odjuricicTT
force-pushed
the
odjuricic/explorer-initial
branch
from
6f58f69 to
18ba484
Compare
odjuricicTT
force-pushed
the
odjuricic/explorer-initial
branch
2 times, most recently
from
1cf8449 to
3b2929b
Compare
|
@nsmithtt I think that your review is required as a codeowner. Can you please take a look? |
odjuricicTT
force-pushed
the
odjuricic/explorer-initial
branch
from
3b2929b to
6cbb8fa
Compare
odjuricicTT
force-pushed
the
odjuricic/explorer-initial
branch
from
6cbb8fa to
87ed18f
Compare
Add minimal version of tt-explorer tool for MLIR visualization:
Next steps:
Closes #934