[Optimizer/TTNN] Migrating Optimizer to TTNN with minimal possible fu… #944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nobradovictt
requested review from
sdjordjevicTT,
svuckovicTT,
mtopalovicTT,
rpavlovicTT,
jserbedzijaTT,
nsmithtt and
mrakitaTT
as code owners
nobradovictt
force-pushed
the
nobradovic/ttnn_optimizer
branch
from
bd9c090 to
94f5a2a
Compare
nsmithtt
approved these changes
Oct 18, 2024
|
FYI @nobradovictt, this PR (#840) might be useful for the layout lowering and the current hacks we have in place. |
odjuricicTT
approved these changes
Oct 21, 2024
| return true; | ||
| } | ||
| if (llvm::isa<ToLayoutOp>(op)) { | ||
|
|
||
| if (llvm::isa<ToLayoutOp>(op) || llvm::isa<ToMemoryConfigOp>(op) || |
There was a problem hiding this comment.
I think we should consider generating layouts for these ops as well in the future. Not in this PR :).
|
|
||
| moduleOp->walk([&](Operation *op) { | ||
| if (op->getNumResults() == 0) { | ||
| return; | ||
| } | ||
|
|
||
| if (!isa<RankedTensorType>(op->getResult(0).getType())) { |
There was a problem hiding this comment.
ttnn.get_device
Thanks, Ill take a look, I need to make a followup change after this one regarding layout change handling in optimizer. |
mtopalovicTT
approved these changes
Oct 22, 2024
nobradovictt
force-pushed
the
nobradovic/ttnn_optimizer
branch
from
94f5a2a to
fb541f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrating Optimizer to TTNN dialect. I tried to minimize functional changes but due to way how currently ToLayoutOp is handled in TTNN lowering and difference between layout attr in TTIR and TTNN dialect special handling was needed for memory management ops. Resharding is broken and will need to be rewritten, but based on inspecting old code it wouldn't have worked in all cases as well. These should be addressed in followup change in sync with changes to TTNN lowering and layout attr.
All tests including Optimizer ones in passing state.
Pure Optimizer pass test has been updated to start from TTNN IR.
Closes #910