-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bringup reduction silicon tests that were previously unsupported #806
Conversation
a846f5e
to
3d0a232
Compare
… eltwise maximum test
3d0a232
to
e1d3c21
Compare
@mrakitaTT, fyi |
@AleksKnezevic These tests will pass because @jnie-TT Thanks for adding more test cases! I've added P.S. I've finally went through setting up a silicon machine because I'll need it for XLA, so going forward I'll manually test everything and not rely on CI. |
@mrakitaTT please note that if you want a test to run on silicon, you need to add it under the Silicon folder. Adding it under the dialect folder will only test the compiler's ability to compile a specific mlir module, but will not generate a flatbuffer for execution on Silicon. |
@jnie-TT Ohh, got it, thanks Jackson! |
I'll merge this in now since we want any future CI to be running these. |
We're using reduction and eltwise maximum ops in tt-xla FE but didn't have silicon tests for them, so we should bring them up.