-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Metal Direct] Implement div op #780
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjanevskiTT
requested review from
rjakovljevicTT,
sdjordjevicTT,
rpavlovicTT,
mrakitaTT,
nobradovictt and
nsmithtt
as code owners
September 20, 2024 15:08
nsmithtt
reviewed
Sep 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks awesome! Minor comments inline.
Clang tidy is a little pedantic:
|
kmitrovicTT
reviewed
Sep 23, 2024
pjanevskiTT
force-pushed
the
pjanevski/generic_metal_div
branch
4 times, most recently
from
September 24, 2024 18:47
60de972
to
99e1b20
Compare
@kmitrovicTT I have rebased on main, since I have changed few things about flow of generating compute init and compute, take a look at that changes |
pjanevskiTT
force-pushed
the
pjanevski/generic_metal_div
branch
from
September 25, 2024 06:37
99e1b20
to
55afd59
Compare
kmitrovicTT
reviewed
Sep 25, 2024
nsmithtt
reviewed
Sep 26, 2024
pjanevskiTT
force-pushed
the
pjanevski/generic_metal_div
branch
from
September 26, 2024 10:29
6c62439
to
20c455e
Compare
nsmithtt
approved these changes
Sep 27, 2024
kmitrovicTT
approved these changes
Sep 27, 2024
pjanevskiTT
force-pushed
the
pjanevski/generic_metal_div
branch
from
October 1, 2024 06:48
4bea10c
to
6f052fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #535
Implement Div op for tt-metal backend.
Important notes for review
Div op is implemented using recip + mul. Input 1 of the div is going to go through the recip using DST register, and then input 0 and recip input 1 are multiplied to get the div.
To avoid intermediate buffers, input 1 CB is used to pack recip tiles of the original input 1. Then input 0 and input 1 are regularly used as inputs for multiply part
More code is moved to convert compute init and convert compute functions, since the code that was outside of those functions was mostly for eltwise ops, and we need to do recip now as well, we cannot keep that code outside of functions
Generated kernel