Add sigmoid op #469
Merged
Add sigmoid op #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svuckovicTT
requested review from
jnie-TT,
kmabeeTT,
AleksKnezevic,
rpavlovicTT,
nobradovictt,
mrakitaTT,
tapspatel and
nsmithtt
as code owners
svuckovicTT
force-pushed
the
svuckovic/add-sigmoid-op
branch
from
9866f4c to
64ddff3
Compare
sdjordjevicTT
approved these changes
Aug 22, 2024
|
Please add a test in one of the folders dedicated to unary ops. :) |
Oh lol, I actually added the test, but forgot to |
topke011
approved these changes
Aug 22, 2024
mtopalovicTT
approved these changes
Aug 22, 2024
rpavlovicTT
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
::ttnn::sigmoid(), but there's also a::ttnn::sigmoid_accurate(), something to keep an eye on once we start running stuff and analyzing accuracy