#452: Added standalone ttrt build #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tapspatel
force-pushed
the
tpatel/issue-452
branch
from
30ac38d to
047eafd
Compare
nsmithtt
approved these changes
Aug 21, 2024
| @@ -75,6 +75,11 @@ def check_global_exists(self, key): | |||
|
|
|||
| return False | |||
|
|
|||
| def add_ld_path(self, path): | |||
There was a problem hiding this comment.
Maybe we should call this get_ld_path? Since it doesn't update the env
There was a problem hiding this comment.
will do. I technically want to remove this altogether but perf mode for ttnn is all relative to TT_METAL_HOME and too tightly integrated in that (slowly unpacking all the paths).
tapspatel
force-pushed
the
tpatel/issue-452
branch
from
047eafd to
16346bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.