-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for stablehlo from tt-mlir project. #447
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usman this looks great, thank you, I think it's looking pretty clean.
Can we add it CI? Enabled on ubuntu, disabled on Mac, that way we kind of get coverage of both build paths?
You have some failing tests, because it's disabled in build:
See config.enable_stablehlo = @TTMLIR_ENABLE_STABLEHLO@ and "@TTMLIR_ENABLE_STABLEHLO@" == "ON" And then inside of if config.enable_stablehlo:
config.available_features.add("stablehlo") Finally, inside of the test: // REQUIRES: stablehlo See https://llvm.org/docs/TestingGuide.html for more info. |
8c9e97f
to
58243b7
Compare
Now failing with:
@vmilosevic will the environment build automatically kick off a new docker build? This used to use GitHub cache This commit updates the env |
No, it's not automated, you need to manually gick off the docker image build. I added a change to build docker images on self-hosted runner, building large images on Github runners sometimes runs out of space and also fails randomly without any log :( Build job: |
My bad, the docker build was always using code from the main, not the current branch 🤦♂️ |
1b829a6
to
a24b381
Compare
…LEHLO flag is set.
a24b381
to
57694f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good on my end, let's get sign off from @vmilosevic on the docker file changes
👍 All is good, Docker changes are my commits |
Add support for stablehlo from tt-mlir project as an embedded project.
Stablehlo is disabled by default and can be enabled by turning on TTMLIR_ENABLE_STABLEHLO flag.