-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support basic row major data movement + tilize/untilize #321 #323 #410
Conversation
3eeffba
to
6820ad0
Compare
The default system desc is missing some info hence the failures, will post a fix for that, but that shouldn't impact the core change. |
f337c83
to
095d5bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice changes!!
PS Took me some time to understand details. I'd be happy to see more comments around the code answering to the question "why?" is something done in certain way.
- Introduce new `LayoutAttr` member `projectOnto` which projects a tensor linear map onto a physical grid. We simply sample this map to generate all data movement. - Read physical cores from the system desc to generate noc coordinates. - Enforce address alignment, could be relaxed per #407
095d5bb
to
5c5ea86
Compare
LayoutAttr
memberprojectOnto
which projects a tensor linear map onto a physical grid. We simply sample this map to generate all data movement.