Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support basic row major data movement + tilize/untilize #321 #323 #410

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

nsmithtt
Copy link
Contributor

  • Introduce new LayoutAttr member projectOnto which projects a tensor linear map onto a physical grid. We simply sample this map to generate all data movement.
  • Read physical cores from the system desc to generate noc coordinates.
  • Enforce address alignment, could be relaxed per Support 16B aligned reads over PCIE #407

@nsmithtt nsmithtt force-pushed the nsmith/kernel6 branch 2 times, most recently from 3eeffba to 6820ad0 Compare August 15, 2024 22:06
@nsmithtt
Copy link
Contributor Author

The default system desc is missing some info hence the failures, will post a fix for that, but that shouldn't impact the core change.

@nsmithtt nsmithtt force-pushed the nsmith/kernel6 branch 2 times, most recently from f337c83 to 095d5bb Compare August 16, 2024 03:22
Copy link
Contributor

@rpavlovicTT rpavlovicTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changes!!

PS Took me some time to understand details. I'd be happy to see more comments around the code answering to the question "why?" is something done in certain way.

lib/Dialect/TT/IR/TTOpsTypes.cpp Outdated Show resolved Hide resolved
lib/Dialect/TT/IR/TTOpsTypes.cpp Outdated Show resolved Hide resolved
lib/Dialect/TTMetal/Transforms/Passes.cpp Show resolved Hide resolved
lib/Dialect/TTMetal/Transforms/Passes.cpp Outdated Show resolved Hide resolved
lib/Dialect/TTMetal/Transforms/Passes.cpp Show resolved Hide resolved
lib/Dialect/TTMetal/Transforms/Passes.cpp Outdated Show resolved Hide resolved
lib/Dialect/TTMetal/Transforms/Passes.cpp Outdated Show resolved Hide resolved
lib/Dialect/TTMetal/Transforms/Passes.cpp Outdated Show resolved Hide resolved
- Introduce new `LayoutAttr` member `projectOnto` which projects a
  tensor linear map onto a physical grid. We simply sample this map to
  generate all data movement.
- Read physical cores from the system desc to generate noc coordinates.
- Enforce address alignment, could be relaxed per #407
lib/Dialect/TTMetal/Transforms/Passes.cpp Show resolved Hide resolved
lib/Dialect/TTMetal/Transforms/Passes.cpp Outdated Show resolved Hide resolved
@nsmithtt nsmithtt merged commit 02f69fa into main Aug 20, 2024
7 checks passed
@nsmithtt nsmithtt deleted the nsmith/kernel6 branch August 20, 2024 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants