Added Pipeline/Transformation from TTIR -> Flatbuffer (#314) #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Interim Update Fixed CMake
nsmithtt
reviewed
Aug 15, 2024
| ctx->appendDialectRegistry(registry); | ||
|
|
||
| const auto pipeline = | ||
| mlir::PassPipelineInfo::lookup("ttir-to-ttnn-backend-pipeline"); |
There was a problem hiding this comment.
Can we just call createTTIRToTTNNBackendPipeline directly?
TTIRToTTNNBackendPipelineOptions options;
//.. maybe set options ..
createTTIRToTTNNBackendPipeline(pm, options);
if (mlir::failed(pm.run(moduleOp))) {
throw std::runtime_error("Failed to run pass manager");
}There was a problem hiding this comment.
I ran it this way in case there was a more involved method to call Pipeline Options. If it's just as simple as editing the struct then that sounds good.
There was a problem hiding this comment.
As mentioned offline, this task will be completed later while I focus on getting E2E working with explorer. Refer to #446 for when that gets completed.
CMake Fix Interim update
nsmithtt
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented
ttir-to-ttnn-backend-pipelineandttnn-to-flatbuffer