Add none type chip capability handling

[jnie-TT]

#380
Add handling for None type chip capability

[kmabeeTT]

LGTM! Thanks!

[kmabeeTT]

Sorry, I deleted my prev reply - I thought there was an issue (seg fault) but I had typo on my cmd (referencing wrong workspace systemdesc). Works good, no more error seen. This looks a bit strange though, is it intended?

    "chip_capabilities": [
      6,
      "None"
    ],

Edit: Maybe lets keep this open a bit to get Nick's thoughts.
Edit2: chatgpt says this bitflag enum should yield values 0,1,3 but we are seeing 6 above for some reason...

enum ChipCapability: uint32 (bit_flags) {
  None = 0,
  PCIE = 1,
  HostMMIO = 2,
}

[jnie-TT]

Sorry, I deleted my prev reply - I thought there was an issue (seg fault) but I had typo on my cmd (referencing wrong workspace systemdesc). Works good, no more error seen. This looks a bit strange though, is it intended?

    "chip_capabilities": [
      6,
      "None"
    ],

Edit: Maybe lets keep this open a bit to get Nick's thoughts. Edit2: chatgpt says this bitflag enum should yield values 0,1,3 but we are seeing 6 above for some reason...

enum ChipCapability: uint32 (bit_flags) {
  None = 0,
  PCIE = 1,
  HostMMIO = 2,
}

You're seeing 6 because with this change you're bitwise or'ing 0b'10 and 0b'100 so it yields 6.

[svuckovicTT]

Curious, what's the use of the None type?

[jnie-TT]

Curious, what's the use of the None type?

Remote chips connected via ethernet.

[svuckovicTT]

Curious, what's the use of the None type?

Remote chips connected via ethernet.

Would it be plausible to call it something like TT_ChipCapabilityEth?

[jnie-TT]

Curious, what's the use of the None type?

Remote chips connected via ethernet.

Would it be plausible to call it something like TT_ChipCapabilityEth?

Yeah that's a good idea! I'll update the name

[nsmithtt]

+1 for adding an eth attribute.

But back to the core issue, does it work instead of using < and > to use [ and ]. Or we could do this instead:

let assemblyFormat = "`<` (`none` `:` $value^)? `>`";

[nsmithtt]

Let's try and support the assembly syntax I posted above. I'd rather not have a special case value for None I think that only works around the issue.

[nsmithtt]

@jnie-TT, we can close this, fixed with #402 right?

[jnie-TT]

@nsmithtt that's correct, closing this.