Renamed params in transpose op #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladimirjovanovicTT
requested review from
jnie-TT,
kmabeeTT,
AleksKnezevic,
sdjordjevicTT,
rpavlovicTT,
nobradovictt,
mrakitaTT,
svuckovicTT,
tapspatel and
nsmithtt
as code owners
nsmithtt
approved these changes
Aug 9, 2024
svuckovicTT
approved these changes
Aug 9, 2024
sdjordjevicTT
requested changes
Aug 12, 2024
There was a problem hiding this comment.
There are two commits in this change. I believe your intention is just to merge:
Modified parameter names for transpose.
vladimirjovanovicTT
force-pushed
the
vladimirjovanovic/rename_params_in_transpose_op
branch
from
9294a7b to
a23bc96
Compare
sdjordjevicTT
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed params in transpose op from (..., dimension1, dimension2) to (..., dimension0, dimension1) to make integration with tt-forge streamlined and to make naming in-line with PyTorch (https://pytorch.org/docs/stable/generated/torch.transpose.html)
https://github.com/tenstorrent/tt-forge/pull/41