Change !tt.tile shape encoding to be consistent with other shape #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously it was:
!tt.tile<32 x 32, bfp8_b>
There was an awkward space between the `x` because of the way we can
legally write the assembly syntax.
Now it uses the same DimensionList custom parser as all other shape
types so we have:
!tt.tile<32x32, bfp8_b>
nsmithtt
requested review from
sdjordjevicTT,
rpavlovicTT,
mrakitaTT and
nobradovictt
as code owners
nobradovictt
approved these changes
Aug 8, 2024
nsmithtt
added a commit
that referenced
this pull request
Aug 9, 2024
Previously it was:
!tt.tile<32 x 32, bfp8_b>
There was an awkward space between the `x` because of the way we can
legally write the assembly syntax.
Now it uses the same DimensionList custom parser as all other shape
types so we have:
!tt.tile<32x32, bfp8_b>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it was:
There was an awkward space between the
xbecause of the way we can legally write the assembly syntax.Now it uses the same DimensionList custom parser as all other shape types so we have: