Additional fixes to metal runtime bootstrap #290 #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nsmithtt
commented
Aug 4, 2024
nsmithtt
commented
- Make inputs per-device (multi-device inputs still need to be worked out)
- Create common functions for creating metal Buffers and CoreRange from flatbuffer types
- Implement wait API + events, update ttrt to use it
- Bug fix logical_grid_size -> compute_with_storage_grid_size, the latter accurately gives post-harvested shape
- Automatically move inputs / outputs during submit
nsmithtt
requested review from
tapspatel,
jnie-TT,
kmabeeTT and
AleksKnezevic
as code owners
nsmithtt
force-pushed
the
nsmith/metal-runtime3
branch
from
d48c38e to
81b81b9
Compare
jnie-TT
reviewed
Aug 6, 2024
- Make inputs per-device (multi-device inputs still need to be worked out) - Create common functions for creating metal Buffers and CoreRange from flatbuffer types - Implement wait API + events, update ttrt to use it - Bug fix logical_grid_size -> compute_with_storage_grid_size, the latter accurately gives post-harvested shape - Automatically move inputs / outputs during submit
nsmithtt
force-pushed
the
nsmith/metal-runtime3
branch
from
81b81b9 to
f2fddea
Compare
pilkicTT
reviewed
Aug 7, 2024
pilkicTT
reviewed
Aug 7, 2024
jnie-TT
approved these changes
Aug 7, 2024
kmabeeTT
approved these changes
Aug 7, 2024
| buffer->set_address(command->ref()->address()); | ||
| buffers[command->ref()->global_id()] = buffer; | ||
| buffers[command->ref()->global_id()] = | ||
| createBufferFromTensorRef(device, command->ref()); |
| executeCommandQueue(device, cq, cq_id, inputs, outputs)); | ||
| ++cq_id; | ||
| } | ||
|
|
||
| Events copyEvents = |
There was a problem hiding this comment.
Just to double check, idea here is that if device outputs need to be copied to host, we will ignore earlier events generated from the execution of programs, by just returning the newer events that represent the copying (reads) of outputs from device to host... seems to make sense.
There was a problem hiding this comment.
Yes, though we don't ignore the earlier events, they are waited on inside of maybeCopyHostOutputs.
|
ttrt code lgtm! |
tapspatel
approved these changes
Aug 7, 2024
nsmithtt
force-pushed
the
nsmith/metal-runtime3
branch
from
b91c0a0 to
13f40c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.