Implement reduction avg op end to end #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgolubovicTT
requested review from
jnie-TT,
kmabeeTT,
AleksKnezevic,
sdjordjevicTT,
rpavlovicTT,
mrakitaTT,
nobradovictt,
svuckovicTT,
tapspatel and
nsmithtt
as code owners
derdeljanTT
reviewed
Aug 1, 2024
| // CHECK: %[[C:.*]] = "ttnn.full"[[C:.*]] | ||
| %0 = tensor.empty() : tensor<512x32xbf16> | ||
| // CHECK: %[[C:.*]] = "ttnn.to_memory_config"[[C:.*]] | ||
| // CHECK: %[[C:.*]] = "ttnn.sum"[[C:.*]] |
There was a problem hiding this comment.
Shouldn't this check be ttnn.avg?
rpavlovicTT
approved these changes
Aug 2, 2024
dgolubovicTT
force-pushed
the
dgolubovic/imp-reduction-avg-op
branch
from
3995fc7 to
e1a68d0
Compare
|
@dgolubovicTT did all CI jobs pass for this? When building locally I'm seeing this error: /localdev/jnie/tt-mlir/runtime/lib/ttnn/program.cpp:210:34: error: no member named 'avg' in namespace 'ttnn'
210 | tensorPool.push_back(::ttnn::avg(in, dim_arg, op->keep_dim()));
| ~~~~~~~~^
1 error generated.
[166/185] Building CXX object python/CMakeFiles/TTMLIRPythonModules.extension._ttmlir.dso.dir/TTModule.cpp.o
ninja: build stopped: subcommand failed. |
dgolubovicTT
added a commit
that referenced
this pull request
Aug 2, 2024
This reverts commit 1ddbd0e due to build break.
|
Seems not. I will revert this one until I solve it. Sorry for that one, still getting used to github pipelines. |
dgolubovicTT
added a commit
that referenced
this pull request
Aug 2, 2024
dgolubovicTT
added a commit
that referenced
this pull request
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #243. Implement avg reduction through TTIR, TTNN dialects and generate flat buffers. Add mapping between dialects for avg op.Add simple_avg.mlir test.