Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RepeatInterleaveOp support #1857

Merged
merged 17 commits into from
Jan 21, 2025
Merged

Add RepeatInterleaveOp support #1857

merged 17 commits into from
Jan 21, 2025

Conversation

mstojkovicTT
Copy link
Contributor

E2E support of RepeatInterleaveOp

jserbedzijaTT
jserbedzijaTT approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@jserbedzijaTT jserbedzijaTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Can you also add a test under test/ttmlir/Silicon/TTNN/perf_unit

include/ttmlir/Dialect/TTIR/IR/TTIROps.td Show resolved Hide resolved
include/ttmlir/Dialect/TTNN/IR/TTNNOps.td Show resolved Hide resolved
lib/Target/TTNN/TTNNToFlatbuffer.cpp Show resolved Hide resolved
azecevicTT
azecevicTT approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@azecevicTT azecevicTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, this looks great, especially for the first PR on MLIR! I've left a couple of comments, dim indexing is the only mandatory thing that needs fixing, everything else is mostly concerned with the style.

include/ttmlir/Dialect/TTIR/IR/TTIROps.td Show resolved Hide resolved
include/ttmlir/Dialect/TTIR/IR/TTIROps.td Outdated Show resolved Hide resolved
include/ttmlir/Dialect/TTNN/IR/TTNNOps.td Outdated Show resolved Hide resolved
lib/Dialect/TTIR/IR/TTIROps.cpp Show resolved Hide resolved
lib/Dialect/TTNN/IR/TTNNOps.cpp Show resolved Hide resolved
lib/Dialect/TTNN/IR/TTNNOps.cpp Outdated Show resolved Hide resolved
lib/Dialect/TTIR/IR/TTIROps.cpp Outdated Show resolved Hide resolved
test/ttmlir/Dialect/TTIR/repeat_interleave/repeat_interleave_tests_positive.mlir Outdated Show resolved Hide resolved
lib/Dialect/TTIR/IR/TTIROps.cpp Outdated Show resolved Hide resolved
@mstojkovicTT mstojkovicTT force-pushed the mstojkovic/add_repeat_interleave branch from ef8b3b6 to eb8faf9 Compare January 17, 2025 10:12
@mstojkovicTT mstojkovicTT force-pushed the mstojkovic/add_repeat_interleave branch from 7c7a7dc to 5f2ef82 Compare January 17, 2025 23:15
tapspatel
tapspatel approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@tapspatel tapspatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome stuff, looks great. Thanks!

@mstojkovicTT mstojkovicTT merged commit 7e0d982 into main Jan 21, 2025
23 checks passed
@mstojkovicTT mstojkovicTT deleted the mstojkovic/add_repeat_interleave branch January 21, 2025 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azecevicTT azecevicTT azecevicTT approved these changes

@jserbedzijaTT jserbedzijaTT jserbedzijaTT approved these changes

@jnie-TT jnie-TT jnie-TT approved these changes

@tapspatel tapspatel tapspatel approved these changes

@kmabeeTT kmabeeTT Awaiting requested review from kmabeeTT kmabeeTT is a code owner

@AleksKnezevic AleksKnezevic Awaiting requested review from AleksKnezevic AleksKnezevic is a code owner

@pilkicTT pilkicTT Awaiting requested review from pilkicTT pilkicTT is a code owner

@sdjordjevicTT sdjordjevicTT Awaiting requested review from sdjordjevicTT sdjordjevicTT is a code owner

@svuckovicTT svuckovicTT Awaiting requested review from svuckovicTT svuckovicTT is a code owner

@mtopalovicTT mtopalovicTT Awaiting requested review from mtopalovicTT mtopalovicTT is a code owner

@nobradovictt nobradovictt Awaiting requested review from nobradovictt

@nsmithtt nsmithtt Awaiting requested review from nsmithtt nsmithtt is a code owner

@mrakitaTT mrakitaTT Awaiting requested review from mrakitaTT mrakitaTT is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mstojkovicTT @tapspatel @jnie-TT @jserbedzijaTT @azecevicTT