Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix of dangling llvm::function_ref #1754

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

azecevicTT
Copy link
Contributor

Closes #1753. The description is in the issue. I decided to change llvm::function_ref to std::function. The other option would be to inline lambda directly as an argument to the addToPipeline.

@vprajapati-tt
Copy link
Contributor

Nice catch! Does this help fix the faulty error handling when running the pipelines?

Copy link
Contributor

@vprajapati-tt vprajapati-tt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@azecevicTT
Copy link
Contributor Author

Nice catch! Does this help fix the faulty error handling when running the pipelines?

Honestly, I wasn't aware of it, spotted it accidentally while looking at some binding code. Is there some open issue related to it?

@vprajapati-tt
Copy link
Contributor

Nice catch! Does this help fix the faulty error handling when running the pipelines?

Honestly, I wasn't aware of it, spotted it accidentally while looking at some binding code. Is there some open issue related to it?

https://github.com/tenstorrent/tt-forge-fe/blob/64a320069ae631deae0699ca12ced4a1576d7a64/forge/csrc/passes/mlir_passes.cpp#L44 Check this out. This might be helpful to forge-fe.

@azecevicTT
Copy link
Contributor Author

Nice catch! Does this help fix the faulty error handling when running the pipelines?

Honestly, I wasn't aware of it, spotted it accidentally while looking at some binding code. Is there some open issue related to it?

https://github.com/tenstorrent/tt-forge-fe/blob/64a320069ae631deae0699ca12ced4a1576d7a64/forge/csrc/passes/mlir_passes.cpp#L44 Check this out. This might be helpful to forge-fe.

Thanks for drawing my attention to this! I will look at this, it might help since it's the same error as this one.

@azecevicTT azecevicTT merged commit f11ee52 into main Jan 14, 2025
21 checks passed
@azecevicTT azecevicTT deleted the azecevic/dangling-function-ref branch January 14, 2025 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using llvm::function_ref to store a lambda
3 participants