-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test Most Elementwise Ops for TTNN #1747
Conversation
4f1aa3f
to
d49fe7b
Compare
d49fe7b
to
e22c17c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome stuff!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Not sure if we want to have many dangling TODOs in the codebase, might be better to tie a github issue number or something? Glad to see op_proxy
was useful :)
Fair point, I can change it to reference the issue number that will fix it. The majority of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
6548ba7
to
3c3c4a2
Compare
This change adds tests for lowerings of most of the remaining elementwise ops in TTNN. The resulting
.ttnn
files can be used to golden test these ops as well. This change does not test all elementwise ops, as there are a few that require a slightly more robust testing system in place to use.Closes #1748