Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Most Elementwise Ops for TTNN #1747

Merged
merged 5 commits into from
Jan 14, 2025
Merged

Test Most Elementwise Ops for TTNN #1747

merged 5 commits into from
Jan 14, 2025

Conversation

ctodTT
Copy link
Contributor

@ctodTT ctodTT commented Jan 10, 2025

This change adds tests for lowerings of most of the remaining elementwise ops in TTNN. The resulting .ttnn files can be used to golden test these ops as well. This change does not test all elementwise ops, as there are a few that require a slightly more robust testing system in place to use.

Closes #1748

@ctodTT ctodTT force-pushed the ctod/test-other-eltwise-ops branch from 4f1aa3f to d49fe7b Compare January 10, 2025 16:25
@ctodTT ctodTT marked this pull request as draft January 10, 2025 16:32
@ctodTT ctodTT force-pushed the ctod/test-other-eltwise-ops branch from d49fe7b to e22c17c Compare January 13, 2025 17:01
@ctodTT ctodTT marked this pull request as ready for review January 13, 2025 17:01
Copy link
Contributor

@tapspatel tapspatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome stuff!

Copy link
Contributor

@vprajapati-tt vprajapati-tt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Not sure if we want to have many dangling TODOs in the codebase, might be better to tie a github issue number or something? Glad to see op_proxy was useful :)

@ctodTT
Copy link
Contributor Author

ctodTT commented Jan 13, 2025

LGTM! Not sure if we want to have many dangling TODOs in the codebase, might be better to tie a github issue number or something? Glad to see op_proxy was useful :)

Fair point, I can change it to reference the issue number that will fix it. The majority of the TODOs (i.e. the ones about the typing stuff) will be fixed with my next PR

Copy link
Contributor

@nsmithtt nsmithtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@ctodTT ctodTT force-pushed the ctod/test-other-eltwise-ops branch from 6548ba7 to 3c3c4a2 Compare January 14, 2025 15:39
@ctodTT ctodTT enabled auto-merge (squash) January 14, 2025 15:43
@ctodTT ctodTT merged commit 043d0a5 into main Jan 14, 2025
19 checks passed
@ctodTT ctodTT deleted the ctod/test-other-eltwise-ops branch January 14, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Test Support for Remaining TTNN Elementwise Ops
4 participants