Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust optimizer team codeowners #1668

Merged
merged 2 commits into from
Dec 27, 2024
Merged

Adjust optimizer team codeowners #1668

merged 2 commits into from
Dec 27, 2024

Conversation

odjuricicTT
Copy link
Contributor

  1. Add additional codeowners for optimizer components to account for Nikola leaving.
  2. Add ownership of TTNN Interface implementation.
  3. Add two more people to own the CODEOWNERS file itself to have more redundancy.

@odjuricicTT
Copy link
Contributor Author

@mbezuljTT Please check if i missed anything from your side?

@mbezuljTT
Copy link
Contributor

@mbezuljTT Please check if i missed anything from your side?

All good from my side, thanks for the ping

mbezuljTT
mbezuljTT approved these changes Dec 26, 2024
View reviewed changes
Copy link
Contributor

@mbezuljTT mbezuljTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good from my side.

just curious - why you haven't removed @nobradovictt from the owners file?

@odjuricicTT
Copy link
Contributor Author

just curious - why you haven't removed @nobradovictt from the owners file?

I'd prefer to remove him after he has officially left the company. Right now he is on PTO.

sdjordjevicTT
sdjordjevicTT approved these changes Dec 26, 2024
View reviewed changes
Copy link
Contributor

@sdjordjevicTT sdjordjevicTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@tt-mpantic
Copy link

Can you add me to CODEOWNERS file too ?

@odjuricicTT odjuricicTT merged commit 0012dad into main Dec 27, 2024
21 checks passed
@odjuricicTT odjuricicTT deleted the odjurcic/codeowners-dec branch December 27, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmilosevic vmilosevic vmilosevic approved these changes

@sdjordjevicTT sdjordjevicTT sdjordjevicTT approved these changes

@mbezuljTT mbezuljTT mbezuljTT approved these changes

@vcanicTT vcanicTT vcanicTT approved these changes

@tt-mpantic tt-mpantic tt-mpantic approved these changes

@milosevic81 milosevic81 milosevic81 approved these changes

@tapspatel tapspatel Awaiting requested review from tapspatel tapspatel is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@odjuricicTT @mbezuljTT @tt-mpantic @milosevic81 @vcanicTT @sdjordjevicTT @vmilosevic