Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uplift third_party/tt-metal to 2a86ff7fdde8561ec6c60f1635937ac2b13e122f 2024-12-27 #1655

Merged
merged 2 commits into from
Dec 27, 2024

Conversation

vmilosevic
Copy link
Contributor

@vmilosevic vmilosevic commented Dec 21, 2024

This PR uplifts the third_party/tt-metal to the 2a86ff7fdde8561ec6c60f1635937ac2b13e122f

@vmilosevic vmilosevic changed the title Uplift third_party/tt-metal to aa4ca74487a7a578b8d19a3460a5553d415ff648 2024-12-21 Uplift third_party/tt-metal to a6019d6abb53c9d6b4c721066495038474bfa72d 2024-12-22 Dec 22, 2024
@vmilosevic vmilosevic changed the title Uplift third_party/tt-metal to a6019d6abb53c9d6b4c721066495038474bfa72d 2024-12-22 Uplift third_party/tt-metal to 91e61c006a9c1900ec90aee8e0898f69574bae04 2024-12-23 Dec 23, 2024
@sdjordjevicTT
Copy link
Contributor

Getting the tt-metal related build failure. I will need to figure out what is going on:

[399/469] Building CXX object ttnn/CMakeFiles/ttnn.dir/Unity/unity_75_cxx.cxx.o
[400/469] Building CXX object ttnn/CMakeFiles/ttnn.dir/Unity/unity_69_cxx.cxx.o
[401/469] Building CXX object ttnn/CMakeFiles/ttnn.dir/Unity/unity_64_cxx.cxx.o
[402/469] Building CXX object ttnn/CMakeFiles/ttnn.dir/Unity/unity_57_cxx.cxx.o
FAILED: ttnn/CMakeFiles/ttnn.dir/Unity/unity_57_cxx.cxx.o 
ccache /usr/bin/clang++-17 -DARCH_WORMHOLE_B0 -DBOOST_CONTAINER_NO_LIB -DBOOST_CONTAINER_STATIC_LINK -DFMT_HEADER_ONLY=1 -DJSON_USE_IMPLICIT_CONVERSIONS=1 -DTTNN_WITH_PYTHON_BINDINGS=1 -Dttnn_EXPORTS -I/localdev/sdjordjevic/src/tt-mlir/third_party/tt-metal/src/tt-metal -I/localdev/sdjordjevic/src/tt-mlir/third_party/tt-metal/src/tt-metal/tt_metal -I/localdev/sdjordjevic/src/tt-mlir/third_party/tt-metal/src/tt-metal/ttnn -I/localdev/sdjordjevic/src/tt-mlir/third_party/tt-metal/src/tt-metal/ttnn/cpp/ttnn/deprecated -I/localdev/sdjordjevic/src/tt-mlir/third_party/tt-metal/src/tt-metal/ttnn/cpp -I/localdev/sdjordjevic/src/tt-mlir/third_party/tt-metal/src/tt-metal/ttnn/cpp/ttnn/experimental/tt_lib -I/localdev/sdjordjevic/src/tt-mlir/third_party/tt-metal/src/tt-metal/tt_metal/third_party/pybind11/include -I/localdev/sdjordjevic/src/tt-mlir/third_party/tt-metal/src/tt-metal/tt_metal/include -I/localdev/sdjordjevic/src/tt-mlir/third_party/tt-metal/src/tt-metal/tt_metal/impl -I/localdev/sdjordjevic/src/tt-mlir/third_party/tt-metal/src/tt-metal/tt_metal/tt_stl -I/localdev/sdjordjevic/src/tt-mlir/third_party/tt-metal/src/tt-metal/tt_metal/third_party/umd/device/api -I/localdev/sdjordjevic/src/tt-mlir/third_party/tt-metal/src/tt-metal/.cpmcache/flatbuffers/2c4062bffa52fa4157b1b4deeae73395df475fda/include -I/localdev/sdjordjevic/src/tt-mlir/third_party/tt-metal/src/tt-metal/tt_metal/hw/inc -I/localdev/sdjordjevic/src/tt-mlir/third_party/tt-metal/src/tt-metal/tt_metal/hw/inc/wormhole -I/localdev/sdjordjevic/src/tt-mlir/third_party/tt-metal/src/tt-metal/tt_metal/hw/inc/wormhole/wormhole_b0_defines -I/localdev/sdjordjevic/src/tt-mlir/third_party/tt-metal/src/tt-metal/tt_metal/third_party/umd/src/firmware/riscv/wormhole -I/localdev/sdjordjevic/src/tt-mlir/third_party/tt-metal/src/tt-metal/tt_metal/third_party/umd/src/firmware/riscv -isystem /usr/include/python3.10 -isystem /localdev/sdjordjevic/src/tt-mlir/third_party/tt-metal/src/tt-metal/.cpmcache/json/230202b6f5267cbf0c8e5a2f17301964d95f83ff/single_include -isystem /localdev/sdjordjevic/src/tt-mlir/third_party/tt-metal/src/tt-metal/.cpmcache/magic_enum/4d76fe0a5b27a0e62d6c15976d02b33c54207096/include -isystem /localdev/sdjordjevic/src/tt-mlir/third_party/tt-metal/src/tt-metal/.cpmcache/fmt/73b5ec45edbd92babfd91c3777a9e1ab9cac8238/include -isystem /localdev/sdjordjevic/src/tt-mlir/third_party/tt-metal/src/tt-metal/.cpmcache/boost_core/e679bef5c160cf29d0f37d549881dc5f5a58c332/include -isystem /localdev/sdjordjevic/src/tt-mlir/third_party/tt-metal/src/tt-metal/.cpmcache/boost_assert/3ab1f6f9db9a884ad9a641164dbb6589a5aa7e2d/include -isystem /localdev/sdjordjevic/src/tt-mlir/third_party/tt-metal/src/tt-metal/.cpmcache/boost_config/0bad5ba3b48288a243894aa801ed6eccbef70b60/include -isystem /localdev/sdjordjevic/src/tt-mlir/third_party/tt-metal/src/tt-metal/.cpmcache/boost_static_assert/4be2778cf9cc81907a60618aede8cc2794ead5e2/include -isystem /localdev/sdjordjevic/src/tt-mlir/third_party/tt-metal/src/tt-metal/.cpmcache/boost_throw_exception/af21673c57a398b5939be5615af8d2614136f98b/include -isystem /localdev/sdjordjevic/src/tt-mlir/third_party/tt-metal/src/tt-metal/.cpmcache/reflect/e75434c4c5f669e4a74e4d84e0a30d7249c1e66f -isystem /localdev/sdjordjevic/src/tt-mlir/third_party/tt-metal/src/tt-metal/tt_metal/third_party/tracy/public -isystem /localdev/sdjordjevic/src/tt-mlir/third_party/tt-metal/src/tt-metal/.cpmcache/boost_container/5fb02b14b46d0d84e7a0ce09e2ea5e963d5d93bd/include -isystem /localdev/sdjordjevic/src/tt-mlir/third_party/tt-metal/src/tt-metal/.cpmcache/boost_intrusive/4a7bf962355d8580809cea3c68f55bbaaa746e64/include -isystem /localdev/sdjordjevic/src/tt-mlir/third_party/tt-metal/src/tt-metal/.cpmcache/boost_move/c59effd88face3140123440bc5425ee60328f08d/include -isystem /localdev/sdjordjevic/src/tt-mlir/third_party/tt-metal/src/tt-metal/.cpmcache/xtensor/4a957e26c765b48cbec4a4235fe9e518d5a85d3d/include -isystem /localdev/sdjordjevic/src/tt-mlir/third_party/tt-metal/src/tt-metal/.cpmcache/xtl/0918808959d33a292c551b9f014a0e808bc4a95c/include -isystem /localdev/sdjordjevic/src/tt-mlir/third_party/tt-metal/src/tt-metal/.cpmcache/xtensor-blas/190c3a4314355b67291a7d78b20a2100de3f8f54/include -isystem /localdev/sdjordjevic/src/tt-mlir/third_party/tt-metal/src/tt-metal/.cpmcache/pybind11/28e94a0cf4e06b65477d5b9052fb47527b539c6f/include -O3 -std=c++20 -fPIC -fvisibility=default -fsized-deallocation -Werror -Wno-deprecated-declarations -Wdelete-non-virtual-dtor -Wreturn-type -Wswitch -Wuninitialized -Wno-unused-parameter -mavx2 -fPIC -fvisibility-inlines-hidden -fno-lto -Wsometimes-uninitialized -Wno-c++11-narrowing -Wno-error=local-type-template-args -Wno-delete-non-abstract-non-virtual-dtor -Wno-c99-designator -Wno-shift-op-parentheses -Wno-non-c-typedef-for-linkage -Wno-deprecated-this-capture -Wno-deprecated-volatile -Wno-deprecated-builtins -MP -Wno-int-to-pointer-cast -fno-var-tracking -Winvalid-pch -Xclang -include-pch -Xclang /localdev/sdjordjevic/src/tt-mlir/third_party/tt-metal/src/tt-metal-build/ttnn/CMakeFiles/ttnn.dir/cmake_pch.hxx.pch -Xclang -include -Xclang /localdev/sdjordjevic/src/tt-mlir/third_party/tt-metal/src/tt-metal-build/ttnn/CMakeFiles/ttnn.dir/cmake_pch.hxx -MD -MT ttnn/CMakeFiles/ttnn.dir/Unity/unity_57_cxx.cxx.o -MF ttnn/CMakeFiles/ttnn.dir/Unity/unity_57_cxx.cxx.o.d -o ttnn/CMakeFiles/ttnn.dir/Unity/unity_57_cxx.cxx.o -c /localdev/sdjordjevic/src/tt-mlir/third_party/tt-metal/src/tt-metal-build/ttnn/CMakeFiles/ttnn.dir/Unity/unity_57_cxx.cxx
In file included from /localdev/sdjordjevic/src/tt-mlir/third_party/tt-metal/src/tt-metal-build/ttnn/CMakeFiles/ttnn.dir/Unity/unity_57_cxx.cxx:37:
/localdev/sdjordjevic/src/tt-mlir/third_party/tt-metal/src/tt-metal/ttnn/cpp/ttnn/operations/ccl/common/host/ccl_command_stream_builders.cpp:130:60: error: invalid operands to binary expression ('std::vector<std::pair<size_t, size_t>>' (aka 'vector<pair<unsigned long, unsigned long>>') and '_Partial<_Transform, decay_t<(lambda at /localdev/sdjordjevic/src/tt-mlir/third_party/tt-metal/src/tt-metal/ttnn/cpp/ttnn/operations/ccl/common/host/ccl_command_stream_builders.cpp:131:31)>>' (aka '_Partial<std::ranges::views::_Transform, (lambda at /localdev/sdjordjevic/src/tt-mlir/third_party/tt-metal/src/tt-metal/ttnn/cpp/ttnn/operations/ccl/common/host/ccl_command_stream_builders.cpp:131:31)>'))
  130 |         compute_evenly_split_sizes(num_pages, num_workers) |
      |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
  131 |         std::views::transform([to_cmd_tensor](auto size_offset) { return to_cmd_tensor(size_offset); });
      |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/cstddef:137:3: note: candidate function not viable: no known conversion from 'std::vector<std::pair<size_t, size_t>>' (aka 'vector<pair<unsigned long, unsigned long>>') to 'byte' for 1st argument
  137 |   operator|(byte __l, byte __r) noexcept
      |   ^         ~~~~~~~~
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/ios_base.h:87:3: note: candidate function not viable: no known conversion from 'std::vector<std::pair<size_t, size_t>>' (aka 'vector<pair<unsigned long, unsigned long>>') to '_Ios_Fmtflags' for 1st argument
   87 |   operator|(_Ios_Fmtflags __a, _Ios_Fmtflags __b)
      |   ^         ~~~~~~~~~~~~~~~~~
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/ios_base.h:129:3: note: candidate function not viable: no known conversion from 'std::vector<std::pair<size_t, size_t>>' (aka 'vector<pair<unsigned long, unsigned long>>') to '_Ios_Openmode' for 1st argument
  129 |   operator|(_Ios_Openmode __a, _Ios_Openmode __b)
      |   ^         ~~~~~~~~~~~~~~~~~
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/ios_base.h:169:3: note: candidate function not viable: no known conversion from 'std::vector<std::pair<size_t, size_t>>' (aka 'vector<pair<unsigned long, unsigned long>>') to '_Ios_Iostate' for 1st argument
  169 |   operator|(_Ios_Iostate __a, _Ios_Iostate __b)
      |   ^         ~~~~~~~~~~~~~~~~
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/atomic_base.h:98:3: note: candidate function not viable: no known conversion from 'std::vector<std::pair<size_t, size_t>>' (aka 'vector<pair<unsigned long, unsigned long>>') to 'memory_order' for 1st argument
   98 |   operator|(memory_order __m, __memory_order_modifier __mod)
      |   ^         ~~~~~~~~~~~~~~~~
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/future:148:20: note: candidate function not viable: no known conversion from 'std::vector<std::pair<size_t, size_t>>' (aka 'vector<pair<unsigned long, unsigned long>>') to 'launch' for 1st argument
  148 |   constexpr launch operator|(launch __x, launch __y) noexcept
      |                    ^         ~~~~~~~~~~
/localdev/sdjordjevic/src/tt-mlir/third_party/tt-metal/src/tt-metal/tt_metal/third_party/umd/device/api/umd/device/tt_silicon_driver_common.hpp:24:34: note: candidate function not viable: no known conversion from 'std::vector<std::pair<size_t, size_t>>' (aka 'vector<pair<unsigned long, unsigned long>>') to 'TensixSoftResetOptions' for 1st argument
   24 | constexpr TensixSoftResetOptions operator|(TensixSoftResetOptions lhs, TensixSoftResetOptions rhs) {
      |                                  ^         ~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/valarray_after.h:412:5: note: candidate template ignored: could not match '_Expr' against 'vector'
  412 |     _DEFINE_EXPR_BINARY_OPERATOR(|, struct std::__bitwise_or)
      |     ^
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/valarray_after.h:344:5: note: expanded from macro '_DEFINE_EXPR_BINARY_OPERATOR'
  344 |     operator _Op(const _Expr<_Dom1, typename _Dom1::value_type>& __v,   \
      |     ^
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/valarray_after.h:412:5: note: candidate template ignored: could not match '_Expr' against 'vector'
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/valarray_after.h:357:5: note: expanded from macro '_DEFINE_EXPR_BINARY_OPERATOR'
  357 |     operator _Op(const _Expr<_Dom, typename _Dom::value_type>& __v,     \
      |     ^
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/valarray_after.h:412:5: note: candidate template ignored: could not match '_Expr' against '_Partial'
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/valarray_after.h:370:5: note: expanded from macro '_DEFINE_EXPR_BINARY_OPERATOR'
  370 |     operator _Op(const typename _Dom::value_type& __t,                  \
      |     ^
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/valarray_after.h:412:5: note: candidate template ignored: could not match '_Expr' against 'vector'
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/valarray_after.h:383:5: note: expanded from macro '_DEFINE_EXPR_BINARY_OPERATOR'
  383 |     operator _Op(const _Expr<_Dom,typename _Dom::value_type>& __e,      \
      |     ^
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/valarray_after.h:412:5: note: candidate template ignored: could not match '_Expr' against '_Partial'
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/valarray_after.h:396:5: note: expanded from macro '_DEFINE_EXPR_BINARY_OPERATOR'
  396 |     operator _Op(const valarray<typename _Dom::value_type>& __v,        \
      |     ^
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/valarray:1193:1: note: candidate template ignored: could not match 'valarray' against 'vector'
 1193 | _DEFINE_BINARY_OPERATOR(|, __bitwise_or)
      | ^
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/valarray:1156:5: note: expanded from macro '_DEFINE_BINARY_OPERATOR'
 1156 |     operator _Op(const valarray<_Tp>& __v, const valarray<_Tp>& __w)    \
      |     ^
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/valarray:1193:1: note: candidate template ignored: could not match 'valarray' against 'vector'
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/valarray:1167:5: note: expanded from macro '_DEFINE_BINARY_OPERATOR'
 1167 |     operator _Op(const valarray<_Tp>& __v,                              \
      |     ^
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/valarray:1193:1: note: candidate template ignored: could not match 'valarray' against '_Partial'
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/valarray:1178:5: note: expanded from macro '_DEFINE_BINARY_OPERATOR'
 1178 |     operator _Op(const typename valarray<_Tp>::value_type& __t,         \
      |     ^
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bitset:1444:5: note: candidate template ignored: could not match 'bitset' against 'vector'
 1444 |     operator|(const bitset<_Nb>& __x, const bitset<_Nb>& __y) _GLIBCXX_NOEXCEPT
      |     ^
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/ranges:809:7: note: candidate template ignored: constraints not satisfied [with _Self = _Partial<_Transform, decay_t<(lambda at /localdev/sdjordjevic/src/tt-mlir/third_party/tt-metal/src/tt-metal/ttnn/cpp/ttnn/operations/ccl/common/host/ccl_command_stream_builders.cpp:131:31)>>, _Range = std::vector<std::pair<size_t, size_t>>]
  809 |       operator|(_Range&& __r, _Self&& __self)
      |       ^
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/ranges:807:5: note: because '__adaptor_invocable<std::ranges::views::__adaptor::_Partial<std::ranges::views::_Transform, (lambda at /localdev/sdjordjevic/src/tt-mlir/third_party/tt-metal/src/tt-metal/ttnn/cpp/ttnn/operations/ccl/common/host/ccl_command_stream_builders.cpp:131:31)>, std::vector<std::pair<unsigned long, unsigned long> > >' evaluated to false
  807 |         && __adaptor_invocable<_Self, _Range>
      |            ^
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/ranges:782:20: note: because 'std::declval<_Adaptor>()(declval<_Args>()...)' would be invalid: no matching function for call to object of type 'std::ranges::views::__adaptor::_Partial<std::ranges::views::_Transform, (lambda at /localdev/sdjordjevic/src/tt-mlir/third_party/tt-metal/src/tt-metal/ttnn/cpp/ttnn/operations/ccl/common/host/ccl_command_stream_builders.cpp:131:31)>'
  782 |       = requires { std::declval<_Adaptor>()(declval<_Args>()...); };
      |                    ^
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/ranges:818:7: note: candidate template ignored: constraints not satisfied [with _Lhs = std::vector<std::pair<size_t, size_t>>, _Rhs = _Partial<_Transform, decay_t<(lambda at /localdev/sdjordjevic/src/tt-mlir/third_party/tt-metal/src/tt-metal/ttnn/cpp/ttnn/operations/ccl/common/host/ccl_command_stream_builders.cpp:131:31)>>]
  818 |       operator|(_Lhs __lhs, _Rhs __rhs)
      |       ^
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/ranges:815:16: note: because 'derived_from<std::vector<std::pair<unsigned long, unsigned long> >, _RangeAdaptorClosure>' evaluated to false
  815 |       requires derived_from<_Lhs, _RangeAdaptorClosure>
      |                ^
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/concepts:67:28: note: because '__is_base_of(std::ranges::views::__adaptor::_RangeAdaptorClosure, std::vector<std::pair<unsigned long, unsigned long> >)' evaluated to false
   67 |     concept derived_from = __is_base_of(_Base, _Derived)
      |                            ^
In file included from /localdev/sdjordjevic/src/tt-mlir/third_party/tt-metal/src/tt-metal-build/ttnn/CMakeFiles/ttnn.dir/Unity/unity_57_cxx.cxx:37:
/localdev/sdjordjevic/src/tt-mlir/third_party/tt-metal/src/tt-metal/ttnn/cpp/ttnn/operations/ccl/common/host/ccl_command_stream_builders.cpp:165:88: error: invalid operands to binary expression ('std::vector<std::pair<size_t, size_t>>' (aka 'vector<pair<unsigned long, unsigned long>>') and '_Partial<_Transform, decay_t<(lambda at /localdev/sdjordjevic/src/tt-mlir/third_party/tt-metal/src/tt-metal/ttnn/cpp/ttnn/operations/ccl/common/host/ccl_command_stream_builders.cpp:166:31)>>' (aka '_Partial<std::ranges::views::_Transform, (lambda at /localdev/sdjordjevic/src/tt-mlir/third_party/tt-metal/src/tt-metal/ttnn/cpp/ttnn/operations/ccl/common/host/ccl_command_stream_builders.cpp:166:31)>'))
  165 |         compute_evenly_split_sizes(input_tensor_shape_in_tiles[split_dim], num_slices) |
      |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
  166 |         std::views::transform([to_cmd_tensor](auto size_offset) { return to_cmd_tensor(size_offset); });
      |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/cstddef:137:3: note: candidate function not viable: no known conversion from 'std::vector<std::pair<size_t, size_t>>' (aka 'vector<pair<unsigned long, unsigned long>>') to 'byte' for 1st argument
  137 |   operator|(byte __l, byte __r) noexcept
      |   ^         ~~~~~~~~
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/ios_base.h:87:3: note: candidate function not viable: no known conversion from 'std::vector<std::pair<size_t, size_t>>' (aka 'vector<pair<unsigned long, unsigned long>>') to '_Ios_Fmtflags' for 1st argument
   87 |   operator|(_Ios_Fmtflags __a, _Ios_Fmtflags __b)
      |   ^         ~~~~~~~~~~~~~~~~~
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/ios_base.h:129:3: note: candidate function not viable: no known conversion from 'std::vector<std::pair<size_t, size_t>>' (aka 'vector<pair<unsigned long, unsigned long>>') to '_Ios_Openmode' for 1st argument
  129 |   operator|(_Ios_Openmode __a, _Ios_Openmode __b)
      |   ^         ~~~~~~~~~~~~~~~~~
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/ios_base.h:169:3: note: candidate function not viable: no known conversion from 'std::vector<std::pair<size_t, size_t>>' (aka 'vector<pair<unsigned long, unsigned long>>') to '_Ios_Iostate' for 1st argument
  169 |   operator|(_Ios_Iostate __a, _Ios_Iostate __b)
      |   ^         ~~~~~~~~~~~~~~~~
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/atomic_base.h:98:3: note: candidate function not viable: no known conversion from 'std::vector<std::pair<size_t, size_t>>' (aka 'vector<pair<unsigned long, unsigned long>>') to 'memory_order' for 1st argument
   98 |   operator|(memory_order __m, __memory_order_modifier __mod)
      |   ^         ~~~~~~~~~~~~~~~~
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/future:148:20: note: candidate function not viable: no known conversion from 'std::vector<std::pair<size_t, size_t>>' (aka 'vector<pair<unsigned long, unsigned long>>') to 'launch' for 1st argument
  148 |   constexpr launch operator|(launch __x, launch __y) noexcept
      |                    ^         ~~~~~~~~~~
/localdev/sdjordjevic/src/tt-mlir/third_party/tt-metal/src/tt-metal/tt_metal/third_party/umd/device/api/umd/device/tt_silicon_driver_common.hpp:24:34: note: candidate function not viable: no known conversion from 'std::vector<std::pair<size_t, size_t>>' (aka 'vector<pair<unsigned long, unsigned long>>') to 'TensixSoftResetOptions' for 1st argument
   24 | constexpr TensixSoftResetOptions operator|(TensixSoftResetOptions lhs, TensixSoftResetOptions rhs) {
      |                                  ^         ~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/valarray_after.h:412:5: note: candidate template ignored: could not match '_Expr' against 'vector'
  412 |     _DEFINE_EXPR_BINARY_OPERATOR(|, struct std::__bitwise_or)
      |     ^
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/valarray_after.h:344:5: note: expanded from macro '_DEFINE_EXPR_BINARY_OPERATOR'
  344 |     operator _Op(const _Expr<_Dom1, typename _Dom1::value_type>& __v,   \
      |     ^
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/valarray_after.h:412:5: note: candidate template ignored: could not match '_Expr' against 'vector'
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/valarray_after.h:357:5: note: expanded from macro '_DEFINE_EXPR_BINARY_OPERATOR'
  357 |     operator _Op(const _Expr<_Dom, typename _Dom::value_type>& __v,     \
      |     ^
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/valarray_after.h:412:5: note: candidate template ignored: could not match '_Expr' against '_Partial'
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/valarray_after.h:370:5: note: expanded from macro '_DEFINE_EXPR_BINARY_OPERATOR'
  370 |     operator _Op(const typename _Dom::value_type& __t,                  \
      |     ^
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/valarray_after.h:412:5: note: candidate template ignored: could not match '_Expr' against 'vector'
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/valarray_after.h:383:5: note: expanded from macro '_DEFINE_EXPR_BINARY_OPERATOR'
  383 |     operator _Op(const _Expr<_Dom,typename _Dom::value_type>& __e,      \
      |     ^
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/valarray_after.h:412:5: note: candidate template ignored: could not match '_Expr' against '_Partial'
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/valarray_after.h:396:5: note: expanded from macro '_DEFINE_EXPR_BINARY_OPERATOR'
  396 |     operator _Op(const valarray<typename _Dom::value_type>& __v,        \
      |     ^
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/valarray:1193:1: note: candidate template ignored: could not match 'valarray' against 'vector'
 1193 | _DEFINE_BINARY_OPERATOR(|, __bitwise_or)
      | ^
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/valarray:1156:5: note: expanded from macro '_DEFINE_BINARY_OPERATOR'
 1156 |     operator _Op(const valarray<_Tp>& __v, const valarray<_Tp>& __w)    \
      |     ^
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/valarray:1193:1: note: candidate template ignored: could not match 'valarray' against 'vector'
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/valarray:1167:5: note: expanded from macro '_DEFINE_BINARY_OPERATOR'
 1167 |     operator _Op(const valarray<_Tp>& __v,                              \
      |     ^
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/valarray:1193:1: note: candidate template ignored: could not match 'valarray' against '_Partial'
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/valarray:1178:5: note: expanded from macro '_DEFINE_BINARY_OPERATOR'
 1178 |     operator _Op(const typename valarray<_Tp>::value_type& __t,         \
      |     ^
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bitset:1444:5: note: candidate template ignored: could not match 'bitset' against 'vector'
 1444 |     operator|(const bitset<_Nb>& __x, const bitset<_Nb>& __y) _GLIBCXX_NOEXCEPT
      |     ^
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/ranges:809:7: note: candidate template ignored: constraints not satisfied [with _Self = _Partial<_Transform, decay_t<(lambda at /localdev/sdjordjevic/src/tt-mlir/third_party/tt-metal/src/tt-metal/ttnn/cpp/ttnn/operations/ccl/common/host/ccl_command_stream_builders.cpp:166:31)>>, _Range = std::vector<std::pair<size_t, size_t>>]
  809 |       operator|(_Range&& __r, _Self&& __self)
      |       ^
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/ranges:807:5: note: because '__adaptor_invocable<std::ranges::views::__adaptor::_Partial<std::ranges::views::_Transform, (lambda at /localdev/sdjordjevic/src/tt-mlir/third_party/tt-metal/src/tt-metal/ttnn/cpp/ttnn/operations/ccl/common/host/ccl_command_stream_builders.cpp:166:31)>, std::vector<std::pair<unsigned long, unsigned long> > >' evaluated to false
  807 |         && __adaptor_invocable<_Self, _Range>
      |            ^
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/ranges:782:20: note: because 'std::declval<_Adaptor>()(declval<_Args>()...)' would be invalid: no matching function for call to object of type 'std::ranges::views::__adaptor::_Partial<std::ranges::views::_Transform, (lambda at /localdev/sdjordjevic/src/tt-mlir/third_party/tt-metal/src/tt-metal/ttnn/cpp/ttnn/operations/ccl/common/host/ccl_command_stream_builders.cpp:166:31)>'
  782 |       = requires { std::declval<_Adaptor>()(declval<_Args>()...); };
      |                    ^
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/ranges:818:7: note: candidate template ignored: constraints not satisfied [with _Lhs = std::vector<std::pair<size_t, size_t>>, _Rhs = _Partial<_Transform, decay_t<(lambda at /localdev/sdjordjevic/src/tt-mlir/third_party/tt-metal/src/tt-metal/ttnn/cpp/ttnn/operations/ccl/common/host/ccl_command_stream_builders.cpp:166:31)>>]
  818 |       operator|(_Lhs __lhs, _Rhs __rhs)
      |       ^
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/ranges:815:16: note: because 'derived_from<std::vector<std::pair<unsigned long, unsigned long> >, _RangeAdaptorClosure>' evaluated to false
  815 |       requires derived_from<_Lhs, _RangeAdaptorClosure>
      |                ^
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/concepts:67:28: note: because '__is_base_of(std::ranges::views::__adaptor::_RangeAdaptorClosure, std::vector<std::pair<unsigned long, unsigned long> >)' evaluated to false
   67 |     concept derived_from = __is_base_of(_Base, _Derived)
      |                            ^
2 errors generated.

@vmilosevic vmilosevic changed the title Uplift third_party/tt-metal to 91e61c006a9c1900ec90aee8e0898f69574bae04 2024-12-23 Uplift third_party/tt-metal to c7e6b43e1dbe966ad6c4b31e95227f85acc17c53 2024-12-24 Dec 24, 2024
@vmilosevic vmilosevic changed the title Uplift third_party/tt-metal to c7e6b43e1dbe966ad6c4b31e95227f85acc17c53 2024-12-24 Uplift third_party/tt-metal to 9f4eb984413f4d9aef8e4c9a253e962cc32b1428 2024-12-25 Dec 25, 2024
@sdjordjevicTT
Copy link
Contributor

The issue with the build has been resolved, now I am starting to investigate failed tests...

@vmilosevic vmilosevic changed the title Uplift third_party/tt-metal to 9f4eb984413f4d9aef8e4c9a253e962cc32b1428 2024-12-25 Uplift third_party/tt-metal to 13661ed434178770e674a0e2db190168923daa87 2024-12-26 Dec 26, 2024
@vmilosevic vmilosevic changed the title Uplift third_party/tt-metal to 13661ed434178770e674a0e2db190168923daa87 2024-12-26 Uplift third_party/tt-metal to 2a86ff7fdde8561ec6c60f1635937ac2b13e122f 2024-12-27 Dec 27, 2024
@sdjordjevicTT
Copy link
Contributor

Validated changes on tt-forge-fe with the following push action:
https://github.com/tenstorrent/tt-forge-fe/actions/runs/12517866044

The CI is red with several failed tests; however, all these failed tests are actual xFail that, with this metal uplift, should pass.

2024-12-27T16:04:42.3781211Z =================================== FAILURES ===================================
2024-12-27T16:04:42.3783177Z ____________________ test_reduce_sum[input_shape15-0-False] ____________________
2024-12-27T16:04:42.3785338Z [XPASS(strict)] tt:exception Unsupported dim
2024-12-27T16:04:42.3786916Z ___________________ test_reduce_mean[input_shape15-0-False] ____________________
2024-12-27T16:04:42.3788359Z [XPASS(strict)] tt:exception Unsupported dim
2024-12-27T16:04:42.3789734Z ____________________ test_reduce_max[input_shape15-0-False] ____________________
2024-12-27T16:04:42.3791188Z [XPASS(strict)] keepdim=False is not supported
2024-12-27T16:04:42.3792560Z =============================== warnings summary ===============================

2024-12-27T16:03:37.1035198Z =================================== FAILURES ===================================
2024-12-27T16:03:37.1036885Z _____________________ test_reduce_sum[input_shape4-0-True] _____________________
2024-12-27T16:03:37.1038446Z [XPASS(strict)] tt:exception Unsupported dim
2024-12-27T16:03:37.1039947Z ____________________ test_reduce_mean[input_shape4-0-True] _____________________
2024-12-27T16:03:37.1041423Z [XPASS(strict)] tt:exception Unsupported dim
2024-12-27T16:03:37.1042848Z _____________________ test_reduce_max[input_shape4-0-True] _____________________
2024-12-27T16:03:37.1044268Z [XPASS(strict)] tt:exception Unsupported dim
2024-12-27T16:03:37.1045541Z =============================== warnings summary ===============================

Based on all of this, I will complete the merge now.

@sdjordjevicTT sdjordjevicTT merged commit 092123c into main Dec 27, 2024
21 checks passed
@sdjordjevicTT sdjordjevicTT deleted the uplift branch December 27, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants