Add options to ttmlir-translate to output C++ from TTKernel dialect
#1602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TT-billteng
force-pushed
the
bteng/shardon_emitc
branch
7 times, most recently
from
d77935c to
3a50482
Compare
TT-billteng
force-pushed
the
bteng/shardon_emitc
branch
from
ecfef6c to
fbd3a0d
Compare
TT-billteng
changed the title
TT-billteng
commented
Dec 28, 2024
| emitKernelAsCpp(mlir::ModuleOp op, llvm::raw_ostream &os, const ttkernel::ThreadType &threadType ) | ||
| { | ||
| std::vector<func::FuncOp> ops; | ||
| op->walk([&](func::FuncOp entry) { |
There was a problem hiding this comment.
Is there a better way to extract the nested FuncOp from ModuleOp?
TT-billteng
commented
Dec 28, 2024
| //TODO: Should generalize this to read kernel type from Attribute? | ||
| void registerTensixKernelToCpp() { | ||
| TranslateFromMLIRRegistration reg( | ||
| "tensixkernel-to-cpp", "translate tensix kernel to C++", |
There was a problem hiding this comment.
Feel like I need to change the option to ttkernel-to-cpp=noc and ttkernel-to-cpp=tensix
There was a problem hiding this comment.
Is this possible? If so, where can I find an example?
TT-billteng
changed the title
ttmlir-translate
TT-billteng
changed the title
ttmlir-translatettmlir-translate to output C++ from TTKernel dialect
TT-billteng
changed the title
ttmlir-translate to output C++ from TTKernel dialectttmlir-translate to output C++ from TTKernel dialect
TT-billteng
requested review from
svuckovicTT,
mtopalovicTT,
nsmithtt and
sdjordjevicTT
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shardon requires emitting C++ from python kernels. To help with the testing and debug process, I've added a TTKernel to C++ target and options to
ttmlir-translateto directly dump C++ from TTKernel dialect.There are separate Noc and Tensix kernel dumping options because shardon users need to explicitly control the definition of Noc and Tensix kernels separately.