Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NoC Mcast Ops in D2M #1100

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Add NoC Mcast Ops in D2M #1100

merged 1 commit into from
Nov 25, 2024

Conversation

jdesousa-TT
Copy link
Contributor

@jdesousa-TT jdesousa-TT commented Oct 29, 2024 •
edited
Loading

Add NoC multicast ops to ttkernel dialect.

The following ops are defined:

  • get_noc_multicast_addr
  • noc_async_write_multicast_one_packet
  • noc_async_write_multicast
  • noc_async_write_multicast_loopback_src

TODO:

  • Add test case that utilizes these ops (likely matmul)
  • buildMulticastNocAsyncTx utility similar to buildNocAsyncTx

nsmithtt
nsmithtt approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@nsmithtt nsmithtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@jdesousa-TT jdesousa-TT marked this pull request as ready for review November 25, 2024 15:56
@jdesousa-TT jdesousa-TT force-pushed the jdesousa/noc-mcast-ops branch 3 times, most recently from 01781b2 to a1f2b84 Compare November 25, 2024 16:07
@jdesousa-TT jdesousa-TT force-pushed the jdesousa/noc-mcast-ops branch from a1f2b84 to 0af7de8 Compare November 25, 2024 16:52
@jdesousa-TT jdesousa-TT enabled auto-merge (squash) November 25, 2024 16:53
@jdesousa-TT jdesousa-TT merged commit f4cfeba into main Nov 25, 2024
18 checks passed
@jdesousa-TT jdesousa-TT deleted the jdesousa/noc-mcast-ops branch November 25, 2024 18:15
jdesousa-TT added a commit that referenced this pull request Nov 25, 2024
@jdesousa-TT
Add NoC Mcast Ops in D2M (#1100)
417da06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsmithtt nsmithtt nsmithtt approved these changes

@rpavlovicTT rpavlovicTT Awaiting requested review from rpavlovicTT

@rjakovljevicTT rjakovljevicTT Awaiting requested review from rjakovljevicTT

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdesousa-TT @nsmithtt