Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for sign op #1086

Merged
merged 4 commits into from
Nov 4, 2024
Merged

Add support for sign op #1086

merged 4 commits into from
Nov 4, 2024

Conversation

ajakovljevicTT
Copy link
Contributor

  • Add end-to-end implementation of the logp1 op
  • Add stablehlo to ttir to ttnn IR conversion of the op
  • Related to issue stable hlo sign #1001

mrakitaTT
mrakitaTT approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@mrakitaTT mrakitaTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing detailed tests!

test/ttmlir/Dialect/TTNN/eltwise/unary/sign/simple_sign.mlir Show resolved Hide resolved
test/ttmlir/Silicon/TTNN/simple_eltwise.mlir Show resolved Hide resolved
tapspatel
tapspatel requested changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@tapspatel tapspatel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you mind adding a sign test under Silicon/TTNN/perf_unit? We added some perf support yesterday (other than that looks awesome)

@ajakovljevicTT ajakovljevicTT force-pushed the ajakovljevic/add_sign_op branch from b3f0ecd to 1dda395 Compare October 31, 2024 15:45
@ajakovljevicTT ajakovljevicTT force-pushed the ajakovljevic/add_sign_op branch from dc6d7e1 to b5ea310 Compare November 4, 2024 09:30
@ajakovljevicTT ajakovljevicTT merged commit 25191b6 into main Nov 4, 2024
18 checks passed
@ajakovljevicTT ajakovljevicTT self-assigned this Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrakitaTT mrakitaTT mrakitaTT approved these changes

@jnie-TT jnie-TT jnie-TT approved these changes

@sdjordjevicTT sdjordjevicTT sdjordjevicTT approved these changes

@svuckovicTT svuckovicTT svuckovicTT approved these changes

@tapspatel tapspatel tapspatel approved these changes

@kmabeeTT kmabeeTT Awaiting requested review from kmabeeTT kmabeeTT is a code owner

@AleksKnezevic AleksKnezevic Awaiting requested review from AleksKnezevic AleksKnezevic is a code owner

@pilkicTT pilkicTT Awaiting requested review from pilkicTT pilkicTT is a code owner

@rpavlovicTT rpavlovicTT Awaiting requested review from rpavlovicTT

@mtopalovicTT mtopalovicTT Awaiting requested review from mtopalovicTT mtopalovicTT is a code owner

@jserbedzijaTT jserbedzijaTT Awaiting requested review from jserbedzijaTT jserbedzijaTT is a code owner

@nobradovictt nobradovictt Awaiting requested review from nobradovictt

@nsmithtt nsmithtt Awaiting requested review from nsmithtt nsmithtt is a code owner

Assignees

@ajakovljevicTT ajakovljevicTT

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ajakovljevicTT @tapspatel @svuckovicTT @sdjordjevicTT @jnie-TT @mrakitaTT