Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using llvm::function_ref to store a lambda #1753

Closed
azecevicTT opened this issue Jan 13, 2025 · 0 comments · Fixed by #1754
Closed

Using llvm::function_ref to store a lambda #1753

azecevicTT opened this issue Jan 13, 2025 · 0 comments · Fixed by #1754
Labels
python Issues pertaining to Python Bindings

Comments

@azecevicTT
Copy link
Contributor

There are two places in python/Passes.cpp where llvm::function_ref is used to store a temporary function object (lambda). It can result in undefined behavior because (as the name suggests) is a non-owning wrapper.

https://llvm.org/doxygen/STLFunctionalExtras_8h_source.html#l00035
@azecevicTT azecevicTT added the python Issues pertaining to Python Bindings label Jan 13, 2025
@azecevicTT azecevicTT mentioned this issue Jan 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
python Issues pertaining to Python Bindings
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bugfix of dangling llvm::function_ref tenstorrent/tt-mlir
1 participant
@azecevicTT