Skip to content

Commit

Permalink
Make SystemDesc's eth and eth_inactive core list optional (#411) (#413)
Browse files Browse the repository at this point in the history
- Empty eth core list happens on N150, this solves MLIR parser issue
   introduced on 8/15 commit d187e56
 - Removes ", eth = []" entirely from MLIR when list is empty, took
   inspiration from chipChannels existing optional param.
  • Loading branch information
kmabeeTT authored Aug 15, 2024
1 parent 29f03dd commit d3426e6
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions include/ttmlir/Dialect/TT/IR/TTOpsTypes.td
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,8 @@ def TT_ChipPhysicalCoresAttr : TT_Attr<"ChipPhysicalCores", "chip_physical_cores
TT chip_physical_cores attribute containing arrays of physical cores by core type in order of logical cores.
}];

let parameters = (ins ArrayRefParameter<"CoreCoordAttr">:$worker, ArrayRefParameter<"CoreCoordAttr">:$dram, ArrayRefParameter<"CoreCoordAttr">:$eth, ArrayRefParameter<"CoreCoordAttr">:$eth_inactive);
let assemblyFormat = "`{` `worker` `=` `[` $worker `]` `,` `dram` `=` `[` $dram `]` `,` `eth` `=` `[` $eth `]` `,` `eth_inactive` `=` `[` $eth_inactive `]` `}`";
let parameters = (ins ArrayRefParameter<"CoreCoordAttr">:$worker, ArrayRefParameter<"CoreCoordAttr">:$dram, OptionalArrayRefParameter<"CoreCoordAttr">:$eth, OptionalArrayRefParameter<"CoreCoordAttr">:$eth_inactive);
let assemblyFormat = "`{` `worker` `=` `[` $worker `]` `,` `dram` `=` `[` $dram `]` (`,` `eth` `=` `[` $eth^ `]`)? (`,` `eth_inactive` `=` `[` $eth_inactive^ `]`)? `}`";
}

def TT_ChipDescAttr : TT_Attr<"ChipDesc", "chip_desc"> {
Expand Down

0 comments on commit d3426e6

Please sign in to comment.