Skip to content

Commit

Permalink
fix parsing of ChipPhysicalCoresAttr
Browse files Browse the repository at this point in the history
Removing commas from `assemblyFormat` so that the parsing of
multiple optional groups works.

It seems that there isn't great support for this kind of parsing
in mlir...
  • Loading branch information
pilkicTT committed Aug 16, 2024
1 parent ac7d6c6 commit ce55c0f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion include/ttmlir/Dialect/TT/IR/TTOpsTypes.td
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ def TT_ChipPhysicalCoresAttr : TT_Attr<"ChipPhysicalCores", "chip_physical_cores
}];

let parameters = (ins ArrayRefParameter<"CoreCoordAttr">:$worker, ArrayRefParameter<"CoreCoordAttr">:$dram, OptionalArrayRefParameter<"CoreCoordAttr">:$eth, OptionalArrayRefParameter<"CoreCoordAttr">:$eth_inactive);
let assemblyFormat = "`{` `worker` `=` `[` $worker `]` `,` `dram` `=` `[` $dram `]` (`,` `eth` `=` `[` $eth^ `]`)? (`,` `eth_inactive` `=` `[` $eth_inactive^ `]`)? `}`";
let assemblyFormat = "`{` `worker` `=` `[` $worker `]` `dram` `=` `[` $dram `]` (`eth` `=` `[` $eth^ `]`)? (`eth_inactive` `=` `[` $eth_inactive^ `]`)? `}`";
}

def TT_ChipDescAttr : TT_Attr<"ChipDesc", "chip_desc"> {
Expand Down

0 comments on commit ce55c0f

Please sign in to comment.