address reviewer comments

tenstorrent · Jan 27, 2025 · cc18937 · cc18937
1 parent 505823a
commit cc18937
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/test/ttmlir/Decomposition/TTIR/reduction/reduce_and.mlir b/test/ttmlir/Decomposition/TTIR/reduction/reduce_and.mlir
@@ -6,7 +6,7 @@ module attributes {} {
     // CHECK-SAME: dim_arg = [3 : i32]
     // CHECK-SAME: keep_dim = false
     // CHECK-SAME: tensor<128x10x32x4xbf16>
-    // CHECK-SAME: -> [[TENSOR:tensor<128x10x32xbf16>]]
+    // CHECK-SAME: -> tensor<128x10x32xbf16>
     // CHECK: return %[[PROD]]
     %0 = tensor.empty() : tensor<128x10x32xbf16>
     %1 = "ttir.reduce_and"(%arg0, %0) <{dim_arg = [3 : i32], keep_dim = false}> : (tensor<128x10x32x4xbf16>, tensor<128x10x32xbf16>) -> tensor<128x10x32xbf16>
@@ -19,7 +19,7 @@ module attributes {} {
     // CHECK-SAME: dim_arg = [1 : i32]
     // CHECK-SAME: keep_dim = false
     // CHECK-SAME: tensor<128x10x4xbf16>
-    // CHECK-SAME: -> [[TENSOR:tensor<128x4xbf16>]]
+    // CHECK-SAME: -> tensor<128x4xbf16>
     // CHECK: return %[[PROD]]
     %0 = tensor.empty() : tensor<128x4xbf16>
     %1 = "ttir.reduce_and"(%arg0, %0) <{dim_arg = [1 : i32], keep_dim = false}> : (tensor<128x10x4xbf16>, tensor<128x4xbf16>) -> tensor<128x4xbf16>
@@ -32,7 +32,7 @@ module attributes {} {
     // CHECK-SAME: dim_arg = [0 : i32]
     // CHECK-SAME: keep_dim = false
     // CHECK-SAME: tensor<128x10xbf16>
-    // CHECK-SAME: -> [[TENSOR:tensor<10xbf16>]]
+    // CHECK-SAME: -> tensor<10xbf16>
     // CHECK: return %[[PROD]]
     %0 = tensor.empty() : tensor<10xbf16>
     %1 = "ttir.reduce_and"(%arg0, %0) <{dim_arg = [0 : i32], keep_dim = false}> : (tensor<128x10xbf16>, tensor<10xbf16>) -> tensor<10xbf16>

diff --git a/test/ttmlir/Silicon/StableHLO/reduction/reduce_and_op.mlir b/test/ttmlir/Silicon/StableHLO/reduction/reduce_and_op.mlir
@@ -9,12 +9,11 @@
 module @jit_reduce_add attributes {} {
   func.func public @test_reduce_and_4to3dim(%arg0: tensor<128x10x32x4xi1>, %cst_0: tensor<i1>) -> tensor<128x10x32xi1> {
     // CHECK-LABEL: func.func public @test_reduce_and_4to3dim
-    // CHECK: %[[SUM:[0-9]+]] = "ttnn.prod"
+    // CHECK: "ttnn.prod"
     // CHECK-SAME: dim_arg = 3
     // CHECK-SAME: keep_dim = false
     // CHECK-SAME: -> tensor<128x10x32xbf16,
     %0 = stablehlo.reduce(%arg0 init: %cst_0) applies stablehlo.and across dimensions = [3] : (tensor<128x10x32x4xi1>, tensor<i1>) -> tensor<128x10x32xi1>
     return %0 : tensor<128x10x32xi1>
   }
-
 }