Enable switching between 1 and 2 cqs in the same process #9832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tt-aho
requested review from
eyonland,
arakhmati,
cfjchu,
xanderchin,
pgkeller,
tt-asaigal,
tt-rkim and
vtangTT
as code owners
tt-aho
force-pushed
the
aho/switch-cqs
branch
3 times, most recently
from
5e2a798 to
ebd9b61
Compare
tt-rkim
approved these changes
Jun 28, 2024
arakhmati
approved these changes
Jun 28, 2024
…num hw cqs to the build key since this affects the bank mappings, and have device pool compile as needed
…g of 1/2 cqs in the same process
tt-asaigal
approved these changes
Jun 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
#9045
Problem description
Could not switch between 1 and 2 cqs in the same process as a number of static objects were initialized based on first num cqs value. num hw cqs also affects fw build (the bank mapping), but wasn't part of the build key.
What's changed
Changed static objects to map / lookup based on num hw cqs and added num cqs to the device build key to trigger new compiles. Updated tests that were previously split due to num cqs back into a single file.
Checklist