Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#9044: Move dispatch core x y to be part of launch msg #9743

Merged
merged 2 commits into from
Jun 28, 2024
Merged

Conversation

tt-aho
Copy link
Contributor

@tt-aho tt-aho commented Jun 26, 2024

which is set in assemble_device_commands. This enables running programs on any cq

Ticket

https://github.com/orgs/tenstorrent/projects/27/views/1?pane=issue&itemId=65701140

Problem description

Dispatch coords for cq 0 were baked into risc fw, which meant we can only run programs on cq 0

What's changed

Moving dispatch coords to launch msg allows us to run programs on any cq

Checklist

  • Post commit CI passes
  • Model regression CI testing passes (if applicable)
  • New/Existing tests provide coverage for changes

@tt-aho tt-aho force-pushed the aho/cq1-programs branch from c3c8f2a to 8a74319 Compare June 28, 2024 13:08
@tt-aho tt-aho merged commit db25a35 into main Jun 28, 2024
80 of 82 checks passed
Copy link
Contributor

@pgkeller pgkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. one question: is the new test_EnqueueProgram code copied from the old random program? If so, can we set up a header and include the implementation? I hate duplicating code if not necessary, my recent experience w/ runtime args shows some of the cost (when the code rots you have to bring it all forward separately).

@tt-aho
Copy link
Contributor Author

tt-aho commented Jun 28, 2024

Yes, it was copied and modified to iterate over num cqs, but should be able to commonize the 1/2cq tests. I'll refactor it

@tt-aho tt-aho deleted the aho/cq1-programs branch June 29, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants