-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#9044: Move dispatch core x y to be part of launch msg #9743
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. one question: is the new test_EnqueueProgram code copied from the old random program? If so, can we set up a header and include the implementation? I hate duplicating code if not necessary, my recent experience w/ runtime args shows some of the cost (when the code rots you have to bring it all forward separately).
Yes, it was copied and modified to iterate over num cqs, but should be able to commonize the 1/2cq tests. I'll refactor it |
which is set in assemble_device_commands. This enables running programs on any cq
Ticket
https://github.com/orgs/tenstorrent/projects/27/views/1?pane=issue&itemId=65701140
Problem description
Dispatch coords for cq 0 were baked into risc fw, which meant we can only run programs on cq 0
What's changed
Moving dispatch coords to launch msg allows us to run programs on any cq
Checklist