#8815: Updating bcast to no longer use run with auto format #9360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eyonland
requested review from
arakhmati,
cfjchu,
xanderchin and
TT-BrianLiu
as code owners
| Tensor zero_like = mk_zero_tensor_like(reference_tensor, output_mem_config); | ||
| Tensor result = bcast(zero_like, k, BcastOpMath::ADD, BcastOpDim::HW, output_mem_config); | ||
| k.deallocate(); |
There was a problem hiding this comment.
when will deallocation happen if not called manually?
| @@ -222,6 +222,18 @@ Tensor triu( | |||
| return tt::tt_metal::triu(input_tensor, diag, memory_config.value_or(input_tensor.memory_config())); | |||
| } | |||
|
|
|||
| // TODO | |||
ayerofieiev-tt
approved these changes
Jun 10, 2024
eyonland
force-pushed
the
ttnn-9302-more-unary-composite-ops
branch
from
31e01b7 to
807a70b
Compare
eyonland
force-pushed
the
ttnn-9302-more-unary-composite-ops
branch
from
6012f8a to
19833a0
Compare
eyonland
force-pushed
the
ttnn-9302-more-unary-composite-ops
branch
from
19833a0 to
80800fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially just trying to get rid of the run with auto format on bcast.