Typecast int32->fp16b #9317
Merged
Typecast int32->fp16b #9317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdjogoTT
force-pushed
the
rd/typecast_to_fp16b
branch
3 times, most recently
from
f6def3f to
f28de2f
Compare
rdjogoTT
requested review from
eyonland,
arakhmati,
cfjchu,
xanderchin,
TT-BrianLiu,
tt-aho,
mywoodstock and
rtawfik01
as code owners
rdjogoTT
force-pushed
the
rd/typecast_to_fp16b
branch
from
f28de2f to
4fbf03d
Compare
rdjogoTT
force-pushed
the
rd/typecast_to_fp16b
branch
from
15a81a9 to
4fbf03d
Compare
rdjogoTT
force-pushed
the
rd/typecast_to_fp16b
branch
from
4fbf03d to
c3e46b2
Compare
TT-BrianLiu
approved these changes
Jun 11, 2024
rtawfik01
reviewed
Jun 11, 2024
| R"doc(Returns tensor with all of the elements of the input tensor ``{0}`` typecasted from bfloat16 to uint32, bfloat16 to uint16, or uint16 to bfloat16.)doc", | ||
| R"doc("Indicates output dtype of typecast", "ttl.tensor.DataType", "")doc" | ||
| ); | ||
| m_tensor.def("eltwise_typecast", &eltwise_typecast, |
There was a problem hiding this comment.
Minor note: Can it be documented either here or in the compute kernel api that GS is not supported for this op?
rtawfik01
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling typecast to fp16b from int32 through SPFU.
Typecast now uses 2 params (one input one output dtype) to differentiate between more combinations of input/output.
Post-commit tests: https://github.com/tenstorrent/tt-metal/actions/runs/9467536575