#8835: Introduce a faster more flexible operation infra v2 #9279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arakhmati
requested review from
eyonland,
cfjchu,
xanderchin,
TT-BrianLiu,
ntarafdar and
kmabeeTT
as code owners
arakhmati
changed the title
arakhmati
force-pushed
the
ttnn-8835-added-tmp-device-op-infra
branch
from
8a97b1c to
6d0b80d
Compare
arakhmati
force-pushed
the
ttnn-8835-added-tmp-device-op-infra
branch
from
6d0b80d to
85ff37e
Compare
mo-tenstorrent
approved these changes
Jun 18, 2024
arakhmati
force-pushed
the
ttnn-8835-added-tmp-device-op-infra
branch
from
1bf4110 to
8439e0c
Compare
arakhmati
force-pushed
the
ttnn-8835-added-tmp-device-op-infra
branch
from
8439e0c to
2bd9fd3
Compare
arakhmati
changed the title
cfjchu
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
#8835
Problem description
Current infrastructure for writing a device operation relies heavily on using std::vectors in the common parts of the infra. They were used because they are easier to understand.
However using vectors causes 2 issues:
What's changed
Added new infra for writing device operations based on template meta-programming
Checklist
Post commit CI - passed
Model regression CI testing running