Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#4625: Multicore runs for untilize with unpadding on interleaved tensors #8622

Merged
merged 1 commit into from
May 20, 2024
Merged

#4625: Multicore runs for untilize with unpadding on interleaved tensors #8622

merged 1 commit into from
May 20, 2024

Conversation

yan-zaretskiy
Copy link
Contributor

This commit adds the ability to run the untilize_with_unpadding op on interleaved tensors across multiple cores.

@yan-zaretskiy yan-zaretskiy force-pushed the yan-zaretskiy/untilize-with-unpadding-interleaved-multicore branch 3 times, most recently from 657a54f to 9a9e380 Compare May 17, 2024 22:53
TT-BrianLiu
TT-BrianLiu approved these changes May 18, 2024
View reviewed changes
Copy link
Contributor

@TT-BrianLiu TT-BrianLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I think we should slowly get rid of single core implementations of these ops

@davorchap
Copy link
Collaborator

Looks good! I think we should slowly get rid of single core implementations of these ops

Definitely!

@yan-zaretskiy
Copy link
Contributor Author

Yeah, we need to add the CB size check in the multicore versions, that's the only missing feature.

@yan-zaretskiy yan-zaretskiy force-pushed the yan-zaretskiy/untilize-with-unpadding-interleaved-multicore branch from 9a9e380 to 3b75a41 Compare May 20, 2024 16:34
@yan-zaretskiy yan-zaretskiy merged commit 363e665 into main May 20, 2024
85 checks passed
@yan-zaretskiy yan-zaretskiy deleted the yan-zaretskiy/untilize-with-unpadding-interleaved-multicore branch May 29, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TT-BrianLiu TT-BrianLiu TT-BrianLiu approved these changes

@arakhmati arakhmati arakhmati approved these changes

@eyonland eyonland Awaiting requested review from eyonland

@cfjchu cfjchu Awaiting requested review from cfjchu cfjchu is a code owner

@xanderchin xanderchin Awaiting requested review from xanderchin

@tt-aho tt-aho Awaiting requested review from tt-aho tt-aho is a code owner

@mywoodstock mywoodstock Awaiting requested review from mywoodstock mywoodstock is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yan-zaretskiy @davorchap @arakhmati @TT-BrianLiu