#8117: Move global_avg_pool2d to C++ #8583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayerofieiev-tt
commented
May 17, 2024
ayerofieiev-tt
commented
May 17, 2024
| @@ -128,32 +133,8 @@ def _torch_global_avg_pool2d(input_tensor: ttnn.Tensor): | |||
| return torch.nn.functional.global_avg_pool2d(input_tensor, output_size) | |||
|
|
|||
|
|
|||
| def _global_avg_pool2d_validate_input_tensors(operation_name, input_tensor, *args, **kwargs): | |||
ayerofieiev-tt
commented
May 17, 2024
ayerofieiev-tt
requested review from
eyonland,
arakhmati,
cfjchu and
xanderchin
as code owners
ayerofieiev-tt
changed the title
ayerofieiev-tt
force-pushed
the
ay/issue-8117-global_avg_pool2d_to_cpp
branch
from
c1964fc to
8e471a3
Compare
arakhmati
approved these changes
May 17, 2024
ayerofieiev-tt
force-pushed
the
ay/issue-8117-global_avg_pool2d_to_cpp
branch
from
8e471a3 to
5618f7f
Compare
cfjchu
reviewed
May 18, 2024
| @@ -50,6 +51,9 @@ void py_module(py::module& module) { | |||
|
|
|||
| auto m_kv_cache = module.def_submodule("kv_cache", "KV cache operations"); | |||
| kv_cache::py_module(m_kv_cache); | |||
|
|
|||
| auto m_pool = module.def_submodule("pool", "pool operations"); | |||
There was a problem hiding this comment.
Might be nicer to rename this to "pooling" to better align with torch:
We can move the Max/Avg pool operations when we migrate those to C++ as well
| @@ -7,7 +7,7 @@ | |||
| #include <pybind11/pybind11.h> | |||
| #include <pybind11/stl.h> | |||
|
|
|||
| #include "../decorators.hpp" | |||
| #include "ttnn/cpp/pybind11/decorators.hpp" | |||
There was a problem hiding this comment.
+1 thanks for refactoring this
| namespace detail { | ||
| inline const std::array<ttnn::TensorSchema, 1> input_tensor_schemas() { | ||
| return {ttnn::TensorSchema{ | ||
| 4, // min rank |
There was a problem hiding this comment.
min/max rank can only be 4?
There was a problem hiding this comment.
I am not sure, relied on python validation info here.
I still struggle to understand real limits of the underlying ops from reading them.
Will gladly take any advice here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#8117