sliding window ops in c++ #8389
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#0: Halo op using new c++ config generation #0: new micro op function for halo to be used in place of utwhv2
…es hash along with it
davorchap
requested changes
May 13, 2024
| const auto& input_tensor_b = input_tensors.at(1); | ||
| const auto& input_tensor_bias = optional_input_tensors.at(0); | ||
| auto& output_tensor = output_tensors.at(0); | ||
| TT_ASSERT(input_tensor_a.memory_config().is_sharded()); // TODO: move this check to validate_input_tensors |
There was a problem hiding this comment.
Any validation of user input, use TT_FATAL
TT_ASSERT is for validating internal behaviour (ie allocated Buffer is not null)
Asserts are disabled in the "release" build for faster speed
TT_FATAL is always on , in all builds ,since we always want to error out if user is not using the OP correctly (even in "release" build)
arakhmati
suggested changes
May 15, 2024
| #include "tt_eager/tt_dnn/op_library/sliding_window_op_infra/halo_op.hpp" | ||
| #include "tt_eager/tt_dnn/op_library/sliding_window_op_infra/sliding_window.hpp" | ||
|
|
||
| using namespace tt; |
There was a problem hiding this comment.
Remove using namespace tt
| #include "tt_eager/tt_dnn/op_library/sliding_window_op_infra/sliding_window.hpp" | ||
| #include "tt_eager/tt_dnn/op_library/sliding_window_op_infra/halo_op.hpp" | ||
|
|
||
| using namespace tt; |
There was a problem hiding this comment.
Remove using namespace tt
mywoodstock
changed the title
|
closing this in favor of: #8623 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.