#8114: Move softplus to ttnn c++ #8366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayerofieiev-tt
requested review from
eyonland,
arakhmati,
cfjchu and
xanderchin
as code owners
|
Nice! |
ayerofieiev-tt
force-pushed
the
ay/issue-8114-softplus
branch
4 times, most recently
from
9d8a34e to
9911688
Compare
xanderchin
reviewed
May 10, 2024
ayerofieiev-tt
force-pushed
the
ay/issue-8114-softplus
branch
from
9911688 to
1b5189b
Compare
tt-rkim
approved these changes
May 13, 2024
… tt_dnn and put it as a dependency for tt_eager/tensor, as you could've seen this error when doing make build && make tests
ayerofieiev-tt
force-pushed
the
ay/issue-8114-softplus
branch
from
cd62a10 to
26e390d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving Softplus (#8114) as part of #5389
Switched from TTL to TTNN binding
Registered softplus as an operation in ttnn C++, bound to python
Moved from activation module to unary
Beta Value and Threshold, as any optional argument, now have to be used by name
Not relying on
ttl.tensor.softplusanymoreC++ implementation of
softpluscurrently only supports 4D shapesI now unsqueeze input to 4D and reshape result back to the original shape.
This required to include ttnn from eager, but thats is aligned with out ongoing effort to merge the two;
Thanks to @arakhmati who basically guided me by hand here!