Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#7996: update sweeps to match validation #8353

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions tests/ttnn/sweep_tests/sweeps/mul.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@
"height": [384, 1024],
"width": [1024, 4096],
"broadcast": [None, "h", "w", "hw"],
"input_a_dtype": [ttnn.bfloat16],
"input_b_dtype": [ttnn.bfloat16],
"input_a_dtype": [ttnn.bfloat16, ttnn.bfloat8_b],
"input_b_dtype": [ttnn.bfloat16, ttnn.bfloat8_b],
"input_a_layout": [ttnn.ROW_MAJOR_LAYOUT, ttnn.TILE_LAYOUT],
"input_b_layout": [ttnn.ROW_MAJOR_LAYOUT, ttnn.TILE_LAYOUT],
"input_b_memory_config": [ttnn.DRAM_MEMORY_CONFIG],
Expand All @@ -27,9 +27,13 @@
}


def skip(*, broadcast, input_b_layout, **_) -> Tuple[bool, Optional[str]]:
def skip(*, broadcast, input_a_layout, input_b_layout, input_a_dtype, input_b_dtype, **_) -> Tuple[bool, Optional[str]]:
if broadcast in {"w", "hw"} and input_b_layout == ttnn.ROW_MAJOR_LAYOUT:
return True, "Broadcasting along width is not supported for row major layout"
if input_a_layout == ttnn.ROW_MAJOR_LAYOUT or input_b_layout == ttnn.ROW_MAJOR_LAYOUT:
return True, "Row major layout not supported"
if input_a_dtype != input_b_dtype:
return True, "Input tensors should be of same dtype"
return False, None


Expand Down
10 changes: 7 additions & 3 deletions tests/ttnn/sweep_tests/sweeps/sub.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@
"height": [384, 1024],
"width": [1024, 4096],
"broadcast": [None, "h", "w", "hw"],
"input_a_dtype": [ttnn.bfloat16],
"input_b_dtype": [ttnn.bfloat16],
"input_a_dtype": [ttnn.bfloat16, ttnn.bfloat8_b],
"input_b_dtype": [ttnn.bfloat16, ttnn.bfloat8_b],
"input_a_layout": [ttnn.ROW_MAJOR_LAYOUT, ttnn.TILE_LAYOUT],
"input_b_layout": [ttnn.ROW_MAJOR_LAYOUT, ttnn.TILE_LAYOUT],
"input_b_memory_config": [ttnn.DRAM_MEMORY_CONFIG],
Expand All @@ -27,9 +27,13 @@
}


def skip(*, broadcast, input_b_layout, **_) -> Tuple[bool, Optional[str]]:
def skip(*, broadcast, input_a_layout, input_b_layout, input_a_dtype, input_b_dtype, **_) -> Tuple[bool, Optional[str]]:
if broadcast in {"w", "hw"} and input_b_layout == ttnn.ROW_MAJOR_LAYOUT:
return True, "Broadcasting along width is not supported for row major layout"
if input_a_layout == ttnn.ROW_MAJOR_LAYOUT or input_b_layout == ttnn.ROW_MAJOR_LAYOUT:
return True, "Row major layout not supported"
if input_a_dtype != input_b_dtype:
return True, "Input tensors should be of same dtype"
return False, None


Expand Down
Loading